feat: optimization of "solid" polygon/polyline display #1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Optimized the algorithm for "solid" polygon/polyline display.
The trick is to use
addPolygon
instead of numerousmoveTo
/lineTo
. It looked like removing redundantmoveTo
s was quite effective, too.Following are some perf tests. We're getting closer to the old solid algorithm (that we had to dismiss because of bugs in 25+ zooms).
Impacted files
polygon_layer/painter.dart
: minor refactoringpolyline_layer/painter.dart
: minor refactoringpixel_hiker.dart
: optimized the "solid pixel hiker" relying onaddPolygon
instead of numerousmoveTo
/lineTo
Screenshots