-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example app (use AndroidX) #575
Conversation
Use kotlin and swift as languages. Support androidx and web. The name was updated to flutter_map_example since it varied across files, and a version number was added.
@dpatrongomez have you tested this? |
Yes, It goes nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it and it works perfectly
You've made a lot of nice changes here that will help people who are new to flutter_map to use, understand and modify the Example. Thanks! |
Some permissions needed to be modified to show a |
I can take a look at it tomorrow. |
I will create a new pull request, as it is easier for me. Before I can do that I'd like to know why this line was included: flutter_map/example/android/build.gradle Line 11 in eb0cf9c
It seems to me as if it is completely unnecessary, as I don't think this library uses any google services, but I could be wrong. Could @raacker maybe elaborate? And then there's this commit 6059181, which seems a bit strange to me. Shouldn't this file be automatically generated? Why are these changes needed, and can this be solved by just regenerating the project @johnpryan? |
Regenerating the XCode project makes sense to me. I'm not sure why |
Okay. I will remove |
Use kotlin and swift as languages. Support androidx and web. The name was updated to flutter_map_example since it varied across files, and a version number was added.
I regenerated the app and copied over the dart files etc. Related to #504.
Tested on android. I would appreciate it if someone could test this on ios (and possibly web). I am not completely sure if the assets work on ios...
If you have any suggestions or find any mistakes here, feel free to point them out :)