Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example app (use AndroidX) #575

Closed
wants to merge 1 commit into from

Conversation

vinicentus
Copy link
Contributor

@vinicentus vinicentus commented Apr 7, 2020

Use kotlin and swift as languages. Support androidx and web. The name was updated to flutter_map_example since it varied across files, and a version number was added.

I regenerated the app and copied over the dart files etc. Related to #504.

Tested on android. I would appreciate it if someone could test this on ios (and possibly web). I am not completely sure if the assets work on ios...

If you have any suggestions or find any mistakes here, feel free to point them out :)

Use kotlin and swift as languages. Support androidx and web. The name was updated to flutter_map_example since it varied across files, and a version number was added.
@vinicentus
Copy link
Contributor Author

@dpatrongomez have you tested this?

@dpatrongomez
Copy link
Contributor

@dpatrongomez have you tested this?

Yes, It goes nice

Copy link
Contributor

@dpatrongomez dpatrongomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried it and it works perfectly

@RichLewis007
Copy link

You've made a lot of nice changes here that will help people who are new to flutter_map to use, understand and modify the Example. Thanks!

@johnpryan
Copy link
Collaborator

Some permissions needed to be modified to show a package:location sample, could you see if it's possible to fix the merge conflicts or re-do these steps?

@vinicentus
Copy link
Contributor Author

I can take a look at it tomorrow.

@vinicentus
Copy link
Contributor Author

vinicentus commented Jul 9, 2020

I will create a new pull request, as it is easier for me.

Before I can do that I'd like to know why this line was included:

classpath 'com.google.gms:google-services:4.2.0'

It seems to me as if it is completely unnecessary, as I don't think this library uses any google services, but I could be wrong.
Could @raacker maybe elaborate?

And then there's this commit 6059181, which seems a bit strange to me. Shouldn't this file be automatically generated? Why are these changes needed, and can this be solved by just regenerating the project @johnpryan?

@johnpryan
Copy link
Collaborator

Regenerating the XCode project makes sense to me. I'm not sure why google-services is necessary, since package:location doesn't require any Android specific configuration: https://pub.dev/packages/location

@vinicentus
Copy link
Contributor Author

vinicentus commented Jul 9, 2020

Okay. I will remove google-services, regenerate the example, and make a new PR.

@johnpryan johnpryan closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants