Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR resolves #576 issue, this problem existed even in 0.8.2 release. Fortunately #572 made it possible to support Tile evict calls.
TileLayerOptions
got aEvictErrorTileStrategy
enum which is currentlynone
by default!Maybe every
TileProvider
should define a default one if user not provides explicitevictErrorTileStrategy
enum, forinstace #564 (-- @bugDim88 anyway what does storage tile caching do with errors? --) may want defaultnone
andothers not
, orMBTilesImageProvider
my usenone
by default because if a Tile not exists on file system then maybe we shouldn't evict Tile image.0.8.2 preview problem:
0.9.0 preview problem:
Preview the fix with
EvictErrorTileStrategy.dispose
this behaves like Leaflet if a Tile not retained anymore, and some time later Tile should be refeched this option simulates it:Preview the fix with
EvictErrorTileStrategy.notVisible
:closes #576