pod: add QUIC benchmarks #516

kckeiks · 2023-04-20T01:31:49Z

Why

Task of #489

I removed the feature flags because AFAIK the plan is to run all tests by default. Please let me know if that's not right.
Client/Server are using a user-provided stream, I added some code to have them return the stream so that users can clean up the stream as needed by the protocol in which UFDP in running on. Open to suggestions of course.

Checklist

~~I have made corresponding changes to the tests~~
I have made corresponding changes to the documentation
I have run the app using my feature and ensured that no functionality is broken

crates/ursa-pod/Cargo.toml

crates/ursa-pod/src/client.rs

kckeiks · 2023-04-20T20:16:06Z

crates/ursa-pod/benches/e2e.rs

+        let mut endpoint = Endpoint::client("0.0.0.0:0".parse().unwrap()).unwrap();
+        let client_config = quinn::ClientConfig::new(Arc::new(client_config()));
+        endpoint.set_default_client_config(client_config);
+        let stream = endpoint


@qti3e @ozwaldorf what's nice about using QUIC here is that we don't have to open iterations connections like in TCP (if we were using TCP + TLS that would be a lot of connection setup overhead). Instead we can open one connection and send each request in a separate QUIC stream. They all get multiplexed in the wire.

This is a really great point, and good to consider when we choose the main transport! I can see this being really useful if a gateway is using many concurrent ufdp connections to a node

ozwaldorf · 2023-04-21T00:05:20Z

crates/ursa-pod/benches/e2e.rs

+
+        #[cfg(feature = "bench-quic")]
+        {
+            let mut g = c.benchmark_group(format!("QUINN UFDP/{range}"));


Minor nit so both impl can be run with QUIC

Suggested change

let mut g = c.benchmark_group(format!("QUINN UFDP/{range}"));

let mut g = c.benchmark_group(format!("QUINN QUIC UFDP/{range}"));

kckeiks · 2023-04-21T00:14:01Z

crates/ursa-pod/benches/e2e.rs

+mod tls_utils {
+    use std::sync::Arc;
+
+    pub struct SkipServerVerification;


I forgot, I'm going to remove this because it would be better to not skip the certificate verification so we can get a better idea of the performance.

Since the iterations in the bench are multiplexed over a single quic connection, this would only affect the initial connection right?

Yes, that's right.

kckeiks · 2023-04-21T01:13:58Z

crates/ursa-pod/benches/e2e.rs

+        content: &'static [u8],
+        tx_started: tokio::sync::oneshot::Sender<u16>,
+    ) {
+        let server_config = ServerConfig::with_crypto(Arc::new(server_config()));


TODO: Make TLS configurable.

ozwaldorf · 2023-04-21T15:35:55Z

Just for visibility, s2n-quic is having an issue on ubuntu 22.04 (it's working on mac only atm):

Benchmarking S2N-QUIC UFDP/Content Size (Kilobyte)/1 request/1: Collecting 20 samples in estimated 11.116 s (8190 iterations)
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: MaxHandshakeDurationExceeded { max_handshake_duration: 10s, source: Location { file: "/home/oz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/s2n-quic-transport-0.18.2/src/connection/connection_imp
l.rs", line: 1027, col: 24 } }', crates/ursa-pod/benches/e2e.rs:510:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: bench failed, to rerun pass `-p ursa-pod --bench e2e`

kckeiks · 2023-04-21T23:45:04Z

Closing for #519

kckeiks added 2 commits April 19, 2023 21:09

Add quinn and s2n-quic benchmarks

7284cc3

Reuse code

e0edbcf

kckeiks changed the base branch from main to feat/pod April 20, 2023 01:32

ozwaldorf reviewed Apr 20, 2023

View reviewed changes

crates/ursa-pod/Cargo.toml Outdated Show resolved Hide resolved

ozwaldorf reviewed Apr 20, 2023

View reviewed changes

crates/ursa-pod/src/client.rs Show resolved Hide resolved

kckeiks added 3 commits April 20, 2023 15:44

Add one feature flag for all quic tests

3bac43d

Clean up

f41488b

Add doc

14918c3

kckeiks force-pushed the pod/quic-e2e-bench branch from d8cba1c to 14918c3 Compare April 20, 2023 19:53

kckeiks added 2 commits April 20, 2023 15:56

Merge branch 'feat/pod' into pod/quic-e2e-bench

6b76e86

Make field private again

8a5b3ef

kckeiks marked this pull request as ready for review April 20, 2023 20:00

kckeiks requested review from ozwaldorf and qti3e April 20, 2023 20:01

Clean up cargo

27fbaf3

kckeiks commented Apr 20, 2023

View reviewed changes

ozwaldorf reviewed Apr 21, 2023

View reviewed changes

kckeiks commented Apr 21, 2023

View reviewed changes

kckeiks closed this Apr 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pod: add QUIC benchmarks #516

pod: add QUIC benchmarks #516

kckeiks commented Apr 20, 2023 •

edited

Loading

kckeiks Apr 20, 2023 •

edited

Loading

ozwaldorf Apr 21, 2023 •

edited

Loading

ozwaldorf Apr 21, 2023

kckeiks Apr 21, 2023

ozwaldorf Apr 21, 2023

kckeiks Apr 21, 2023

kckeiks Apr 21, 2023

ozwaldorf commented Apr 21, 2023 •

edited

Loading

kckeiks commented Apr 21, 2023

	let mut g = c.benchmark_group(format!("QUINN UFDP/{range}"));
	let mut g = c.benchmark_group(format!("QUINN QUIC UFDP/{range}"));

pod: add QUIC benchmarks #516

pod: add QUIC benchmarks #516

Conversation

kckeiks commented Apr 20, 2023 • edited Loading

Why

Checklist

kckeiks Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

ozwaldorf Apr 21, 2023 • edited Loading

Choose a reason for hiding this comment

ozwaldorf Apr 21, 2023

Choose a reason for hiding this comment

kckeiks Apr 21, 2023

Choose a reason for hiding this comment

ozwaldorf Apr 21, 2023

Choose a reason for hiding this comment

kckeiks Apr 21, 2023

Choose a reason for hiding this comment

kckeiks Apr 21, 2023

Choose a reason for hiding this comment

ozwaldorf commented Apr 21, 2023 • edited Loading

kckeiks commented Apr 21, 2023

kckeiks commented Apr 20, 2023 •

edited

Loading

kckeiks Apr 20, 2023 •

edited

Loading

ozwaldorf Apr 21, 2023 •

edited

Loading

ozwaldorf commented Apr 21, 2023 •

edited

Loading