Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

fix: 🐛 use axums fix "Fix fallback panic on CONNECT requests" #525

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

heldrida
Copy link
Member

@heldrida heldrida commented Apr 25, 2023

Why

Fix for fallback panic on CONNECT requests that was initially reported here #522, and fix provided here tokio-rs/axum#1958

Fixes # (issue)

#522

What

Demo

Native build via the assisted installer

Screenshot 2023-04-25 at 13 57 30

This is a test where the ursa-proxy runs along the ursa build natively through cargo commands and not via the assisted installer

Screenshot 2023-04-25 at 13 58 11

Notes

Checklist

  • I have made corresponding changes to the tests
  • I have made corresponding changes to the documentation
  • I have run the app using my feature and ensured that no functionality is broken

@heldrida heldrida marked this pull request as ready for review April 25, 2023 13:01
@heldrida heldrida changed the title fix: 🐛 use axums "Fix fallback panic on CONNECT requests" fix: 🐛 use axums fix "Fix fallback panic on CONNECT requests" Apr 25, 2023
@heldrida heldrida merged commit 1beee3e into main Apr 26, 2023
@heldrida heldrida deleted the fix/panic-on-connect-requests branch April 26, 2023 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants