Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ktor-http Dependency from ksoup-core by Implementing String.resolveOrNull in Pure Kotlin #65

Closed
itboy87 opened this issue Sep 9, 2024 · 0 comments · Fixed by #81
Closed

Remove ktor-http Dependency from ksoup-core by Implementing String.resolveOrNull in Pure Kotlin #65

itboy87 opened this issue Sep 9, 2024 · 0 comments · Fixed by #81
Labels
enhancement New feature or request

Comments

@itboy87
Copy link
Collaborator

itboy87 commented Sep 9, 2024

The current implementation of this function in the kotlinx variant relies on the ktor-http dependency. This introduces an unnecessary dependency into the ksoup-core module.

Proposed Solution

Implement the String.resolveOrNull function in pure Kotlin. This change will remove the need for the ktor-http dependency within ksoup-core, making the library more lightweight and modular.
@itboy87 itboy87 added the enhancement New feature or request label Sep 9, 2024
@itboy87 itboy87 mentioned this issue Sep 9, 2024
Closed
6 tasks
itboy87 added a commit that referenced this issue Sep 11, 2024
@itboy87
Fixes #65
13a6f66 
Remove ktor-http Dependency from ksoup-core by Implementing String.resolveOrNull in Pure Kotlin
@itboy87 itboy87 mentioned this issue Sep 11, 2024
Merged
itboy87 added a commit that referenced this issue Sep 11, 2024
@itboy87
Fixes #65 (#73)
6cf3b52 
Remove ktor-http Dependency from ksoup-core by Implementing String.resolveOrNull in Pure Kotlin
@itboy87 itboy87 closed this as completed Sep 11, 2024
@itboy87 itboy87 mentioned this issue Sep 17, 2024
Merged
itboy87 added a commit that referenced this issue Sep 18, 2024
@itboy87
Release 0.1.8 (#81)
b4307aa 
* Fixes #65 (#73)

Remove ktor-http Dependency from ksoup-core by Implementing String.resolveOrNull in Pure Kotlin

* Implement KMP CodePoint and remove external dependency (#75)

Fixes #74
Create a pure Kotlin implementation for CodePoint & remove the external dependency for CodePoint

* fix charbuf NPE

* add isUtf8Only flag for charset

* update extension function for SourceReader

* fix clock millis

* add ksoup-lite variant (#77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.1.8 fleeksoft/ksoup
1 participant
@itboy87