Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing install scripts adds \r to scripts #22196

Closed
lucasmrod opened this issue Sep 18, 2024 · 3 comments
Closed

Editing install scripts adds \r to scripts #22196

lucasmrod opened this issue Sep 18, 2024 · 3 comments
Assignees
@iansltx
Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Milestone
4.57.0

Comments

@lucasmrod
Copy link
Member

lucasmrod commented Sep 18, 2024 •
edited
Loading

Editing any install script will add \r to all scripts of a software package. This caused issues on my Ubuntu VM (because of the shebang).

Steps to reproduce:

https://www.loom.com/share/ffc8313f3dea448d980ba30aa45d8b78
@lucasmrod lucasmrod added bug Something isn't working as documented :reproduce Involves documenting reproduction steps in the issue #g-endpoint-ops Endpoint ops product group ~unreleased bug This bug was found in an unreleased version of Fleet. :incoming New issue in triage process. labels Sep 18, 2024
@lucasmrod lucasmrod added this to the 4.57.0 milestone Sep 18, 2024
@lucasmrod lucasmrod mentioned this issue Sep 18, 2024
Closed
iansltx added a commit that referenced this issue Sep 18, 2024
@iansltx
Ensure edited scripts provided from the client with newline switches …
962e85c 
…and no other changes get converted to "\n" (#22196)
@iansltx
Copy link
Member

iansltx commented Sep 18, 2024

This affects scripts that, after cleaning up newlines, would be identical to the script in the ddatabase. Attaching verified fix PR in a sec.

@iansltx iansltx removed :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. labels Sep 18, 2024
@iansltx iansltx self-assigned this Sep 18, 2024
@iansltx iansltx added the :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. label Sep 18, 2024
iansltx added a commit that referenced this issue Sep 18, 2024
@iansltx
Ensure edited scripts provided from the client with newline switches …
ea2a978 
…and no other changes get converted to "\n" (#22196) (#22199)

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
iansltx added a commit that referenced this issue Sep 18, 2024
@iansltx
Ensure edited scripts provided from the client with newline switches …
830b44b 
…and no other changes get converted to "\n" (#22196) (#22199)

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
iansltx added a commit that referenced this issue Sep 18, 2024
@iansltx
Cherry-pick: Ensure edited scripts provided from the client with newl…
7d36b1b 
…ine switches and no other changes get converted to "\n" (#22196) (#22202)

Merged to `main` in #22199.

```
git checkout minor-fleet-v4.57.0
git checkout -b 22196-cherry-pick
git cherry-pick ea2a978
git push -u origin 22196-cherry-pick
```
@lucasmrod
Copy link
Member Author

I've QAd. the linked PR. Works now. Thanks!

@fleet-release
Copy link
Contributor

Script editing flows,
No \r, Ubuntu grows,
In cloud city, peace shows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iansltx iansltx

Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Milestone
4.57.0
Development

No branches or pull requests
4 participants
@iansltx @lucasmrod @lukeheath @fleet-release