Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article: guide configuring maintenance windows #20974

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

spokanemac
Copy link
Contributor

Article: Guide configuring maintenance windows in Fleet. #20763

cc: @getvictor @sharon-fdm

fleet-release
fleet-release previously approved these changes Aug 1, 2024
@spokanemac
Copy link
Contributor Author

Since this feature has already shipped, we could publish ASAP.

@sharon-fdm
Copy link
Collaborator

@spokanemac, awesome writing!
See comments.

fleet-release
fleet-release previously approved these changes Aug 2, 2024
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

articles/configuring-maintenance-windows-in-fleet.md Outdated Show resolved Hide resolved
articles/configuring-maintenance-windows-in-fleet.md Outdated Show resolved Hide resolved
articles/configuring-maintenance-windows-in-fleet.md Outdated Show resolved Hide resolved
articles/configuring-maintenance-windows-in-fleet.md Outdated Show resolved Hide resolved
articles/configuring-maintenance-windows-in-fleet.md Outdated Show resolved Hide resolved
articles/configuring-maintenance-windows-in-fleet.md Outdated Show resolved Hide resolved
articles/configuring-maintenance-windows-in-fleet.md Outdated Show resolved Hide resolved
Co-authored-by: Victor Lyuboslavsky <victor.lyuboslavsky@gmail.com>
fleet-release
fleet-release previously approved these changes Aug 2, 2024
fleet-release
fleet-release previously approved these changes Aug 2, 2024
fleet-release
fleet-release previously approved these changes Aug 2, 2024
sharon-fdm
sharon-fdm previously approved these changes Aug 2, 2024
Copy link
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lukeheath lukeheath marked this pull request as ready for review August 9, 2024 15:51
lukeheath
lukeheath previously approved these changes Aug 9, 2024
@lukeheath lukeheath marked this pull request as draft August 9, 2024 15:51
@lukeheath
Copy link
Member

@spokanemac I almost merged this, but then remembered that we likely want to hold this and any articles or guides about scheduled maintenance until we have the DDM OS update flow in place.

Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
fleet-release
fleet-release previously approved these changes Aug 29, 2024
@lukeheath lukeheath added this to the 4.57.0 milestone Sep 20, 2024
@lukeheath lukeheath marked this pull request as ready for review September 23, 2024 21:17
@lukeheath lukeheath marked this pull request as draft September 23, 2024 21:18
@lukeheath lukeheath removed this from the 4.57.0 milestone Sep 23, 2024
@spokanemac spokanemac marked this pull request as ready for review September 23, 2024 21:37
@lukeheath
Copy link
Member

Converting to draft since we want to wait to publish this until we have more time to work on the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants