Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CIS policy for tests #22112

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add CIS policy for tests #22112

merged 3 commits into from
Sep 17, 2024

Conversation

sharon-fdm
Copy link
Collaborator

No description provided.

<key>PayloadType</key>
<string>com.apple.Safari</string>
<key>PayloadIdentifier</key>
<string>com.fleetdm.cis-Ensure Show Status Bar Is Enabled</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see spaces on other profiles. Let's remove just in case. (replace spaces with - and all lowercase)

<key>PayloadDisplayName</key>
<string>Ensure Show Status Bar Is Enabled</string>
<key>PayloadIdentifier</key>
<string>com.fleetdm.cis-Ensure Show Status Bar Is Enabled</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and use a different identifier than the one above (check patters we use from other configuration profiles on this directory).

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some comments around PayloadIdentifier.

@sharon-fdm sharon-fdm merged commit b11edd9 into main Sep 17, 2024
4 checks passed
@sharon-fdm sharon-fdm deleted the cis-profile-addition branch September 17, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants