Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Add search and breadcrumbs to article template page #22171

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

eashaw
Copy link
Contributor

@eashaw eashaw commented Sep 17, 2024

Closes: #15857
Closes: #21850

Changes:

  • Updated the article page template to include a search input and breadcrumb links.

fleet-release
fleet-release previously approved these changes Sep 17, 2024
Copy link
Member

@mike-j-thomas mike-j-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's missing the search box.

@mike-j-thomas
Copy link
Member

@eashaw, I updated the wireframes to include mobile layouts. (Just need to stack the breadcrumbs and search from 991px and below, and reduce the top page margin to 32px for 767px and below.)

Copy link
Member

@mike-j-thomas mike-j-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eashaw !

@mike-j-thomas mike-j-thomas merged commit 721ed30 into main Sep 18, 2024
6 checks passed
@mike-j-thomas mike-j-thomas deleted the website-update-article-template-page branch September 18, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add search to articles Request: Breadcrumb link for blog posts
3 participants