Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: handle possibly 'null' 'storedPolicy.team_id' on update policy call #22215

Merged
merged 1 commit into from
Sep 18, 2024
Merged

UI: handle possibly 'null' 'storedPolicy.team_id' on update policy call #22215

merged 1 commit into from
Sep 18, 2024

Conversation

jacobshandling
Copy link
Contributor

#22145

ezgif-2-c62195a3ba

  • Changes file added for user-visible changes in changes/
  • Manual QA for all new/changed functionality

@jacobshandling jacobshandling requested a review from a team as a code owner September 18, 2024 16:44
@jacobshandling jacobshandling merged commit 4ee79ae into main Sep 18, 2024
7 checks passed
@jacobshandling jacobshandling deleted the 22145-update-all-teams-policy branch September 18, 2024 16:47
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.19%. Comparing base (f7fab00) to head (48b8575).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #22215   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files        1495     1495           
  Lines      117104   117104           
  Branches     3562     3513   -49     
=======================================
  Hits        76347    76347           
- Misses      33635    33636    +1     
+ Partials     7122     7121    -1
Flag Coverage Δ
frontend 52.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jacobshandling added a commit that referenced this pull request Sep 18, 2024
@jacobshandling
UI: handle possibly 'null' 'storedPolicy.team_id' on update policy ca…
37535d0 
…ll (#22215)

## #22145 


![ezgif-2-c62195a3ba](https://github.com/user-attachments/assets/4db3fcf8-f706-40e5-a1e5-c422ff7ac6c6)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@jacobshandling jacobshandling mentioned this pull request Sep 18, 2024
Merged
jacobshandling added a commit that referenced this pull request Sep 18, 2024
@jacobshandling
to RC: UI: handle possibly 'null' 'storedPolicy.team_id' on update po…
a3232b2 
…licy ca… (#22216)

#### This PR already merged to `main`, see
#22215. This is against the release
branch so it can be included in 4.57.0 (issue #22145 )

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RachelElysia RachelElysia RachelElysia approved these changes

Assignees

@RachelElysia RachelElysia

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobshandling @RachelElysia