Add doc API changes for the now async software batch #22259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
4 tasks
There was a problem hiding this comment.
Hey @lucasmrod I just left a couple of small suggestions/questions, otherwise looks good to me!
Co-authored-by: Marko Lisica <83164494+marko-lisica@users.noreply.github.com>
lucasmrod
had a problem deploying
to
Docker Hub
GitHub Actions
Error
lucasmrod
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
marko-lisica
previously approved these changes
Sep 20, 2024
lucasmrod
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
lucasmrod
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
lucasmrod
added a commit
that referenced
this pull request
Sep 20, 2024
#22069 API changes: #22259 QAd by applying 10 pieces of software on a team, which took 3+ minutes in total (which, before these changes was timing out at 100s.) With this approach, a GitOps CI run timing out might leave the background process running (which will eventually be applied to the database). The team discussed and agreed that we can fix this edge case later. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated tests - [X] Manual QA for all new/changed functionality
lucasmrod
added a commit
that referenced
this pull request
Sep 20, 2024
#22069 API changes: #22259 QAd by applying 10 pieces of software on a team, which took 3+ minutes in total (which, before these changes was timing out at 100s.) With this approach, a GitOps CI run timing out might leave the background process running (which will eventually be applied to the database). The team discussed and agreed that we can fix this edge case later. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated tests - [X] Manual QA for all new/changed functionality
fleet-release
approved these changes
Sep 23, 2024
noahtalerman
had a problem deploying
to
Docker Hub
GitHub Actions
Error
fleet-release
previously approved these changes
Sep 23, 2024
lukeheath
previously approved these changes
Sep 23, 2024
noahtalerman
dismissed stale reviews from lukeheath and fleet-release
via
ac2ee87
fleet-release
approved these changes
Sep 23, 2024
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
lukeheath
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes for #22069.