-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove placeholder text #22274
Remove placeholder text #22274
Conversation
- It's unclear, at a glance, when I'm enforcing updates and when I'm not
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22274 +/- ##
=======================================
Coverage 65.20% 65.20%
=======================================
Files 1496 1496
Lines 117239 117239
Branches 3512 3571 +59
=======================================
Hits 76447 76447
+ Misses 33656 33655 -1
- Partials 7136 7137 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @iansltx! I didn't get a chance to QA this myself. Did you give it a quick check? @sharon-fdm, assuming Ian helped QA, is it ok for me to merge this now? I'm not sure where we stand w/ 4.57 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused code:
const getMinimumVersionPlaceholder = (platform: ApplePlatform) => {
switch (platform) {
case "darwin":
return "13.0.1";
case "ios":
case "ipados":
return "17.5.1";
default:
return "";
}
};
frontend/pages/ManageControlsPage/OSUpdates/components/AppleOSTargetForm/AppleOSTargetForm.tsx
Outdated
Show resolved
Hide resolved
@RachelElysia, can you please remind me which ticket this is for? |
@sharon-fdm - I don't know if this has a ticket. It looks like @noahtalerman just saw a UI improvement (these placeholders are released) and wanted to snipe it real quick. |
Ahhhhh... sounds good. |
IMO no exception here, as we can pick this up in 4.57.1, and 4.57.0 is frozen for smoke testing at this point. |
@noahtalerman I can QA, but will need a ticket so this doesn't get lost, as I still have some docs to write. |
(and also Rachel's review absolutely wins over mine, so there's a little extra work to do here) |
Issue
Cerra #22278
Description
Screenrecording of fix
https://www.loom.com/share/774b1f8180054ed69a0c6bdd53897acf