Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to prevent race in profile adding and deleting #22338

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Sep 24, 2024

Follow up on: #21891

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

@jahzielv jahzielv marked this pull request as ready for review September 24, 2024 19:00
@jahzielv jahzielv requested a review from a team as a code owner September 24, 2024 19:01
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.10%. Comparing base (80f0fd8) to head (8791530).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/apple_mdm.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22338   +/-   ##
=======================================
  Coverage   65.10%   65.10%           
=======================================
  Files        1496     1496           
  Lines      117000   117036   +36     
  Branches     3535     3535           
=======================================
+ Hits        76168    76199   +31     
- Misses      33745    33751    +6     
+ Partials     7087     7086    -1     
Flag Coverage Δ
backend 66.37% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahzielv jahzielv merged commit 24c84ed into main Oct 1, 2024
26 checks passed
@jahzielv jahzielv deleted the jve-fix-profile-race branch October 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants