Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Improve select targets dropdown #22348

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

RachelElysia
Copy link
Member

Issue

Cerra #21276

Description

Select targets "searchy dropdown" improvements

  • Dropdown loading state doesn't push UI at all
  • Dropdown loading state, error state, and empty state all 225px (unless there is a search result, it's the height of the result)
  • Loading spinner centered on dropdown
  • Clicking out of results now closes the results except when loading (because results will reopen when loaded)

Screen recording of improvements

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.22%. Comparing base (dfc7289) to head (2d1fb93).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...components/LiveQuery/TargetsInput/TargetsInput.tsx 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22348      +/-   ##
==========================================
- Coverage   65.22%   65.22%   -0.01%     
==========================================
  Files        1496     1496              
  Lines      117247   117259      +12     
  Branches     3573     3516      -57     
==========================================
+ Hits        76477    76483       +6     
- Misses      33633    33640       +7     
+ Partials     7137     7136       -1     
Flag Coverage Δ
frontend 52.38% <72.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few questions here for my understanding. Once I get those answered, LGTM. Keeping feedback as blocking since getting this in isn't urgent.

@RachelElysia RachelElysia merged commit 18026d5 into main Sep 25, 2024
14 checks passed
@RachelElysia RachelElysia deleted the 21276-select-targets-fixes branch September 25, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants