Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating scep package with latest fixes #22372

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Updating scep package with latest fixes #22372

merged 4 commits into from
Sep 27, 2024

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Sep 25, 2024

Updating scep package with changes up to github.com/micromdm/scep@781f8042a79cabcf61a5e6c01affdbadcb785932
Fixes needed for NDES client for #21955

Manually pulled in the recent changes. You can view the changes in the remote like:
getvictor/scep@fleet...micromdm:scep:main

@getvictor getvictor marked this pull request as ready for review September 25, 2024 19:43
@getvictor getvictor requested a review from a team as a code owner September 25, 2024 19:43
@getvictor
Copy link
Member Author

@roperzh Assigning the review to you since this might impact MDM SCEP

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 54 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (ea0175e) to head (1c12fbc).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
server/mdm/scep/depot/file/depot.go 19.23% 20 Missing and 1 partial ⚠️
server/mdm/scep/cmd/scepclient/scepclient.go 0.00% 20 Missing ⚠️
server/mdm/scep/depot/signer.go 37.50% 4 Missing and 1 partial ⚠️
server/mdm/scep/cmd/scepserver/scepserver.go 0.00% 3 Missing ⚠️
server/mdm/scep/csrverifier/csrverifier.go 0.00% 3 Missing ⚠️
server/mdm/scep/cmd/scepclient/csr.go 0.00% 1 Missing ⚠️
server/mdm/scep/depot/bolt/depot.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22372      +/-   ##
==========================================
+ Coverage   65.17%   65.20%   +0.02%     
==========================================
  Files        1496     1494       -2     
  Lines      117013   116839     -174     
  Branches     3573     3573              
==========================================
- Hits        76265    76185      -80     
+ Misses      33623    33574      -49     
+ Partials     7125     7080      -45     
Flag Coverage Δ
backend 66.48% <45.45%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! can spot anything that might break, but this is "easy" to test and will be thoroughly covered by regular QA

@getvictor getvictor merged commit e0faa14 into main Sep 27, 2024
26 of 27 checks passed
@getvictor getvictor deleted the victor/scep-update branch September 27, 2024 12:04
RachelElysia pushed a commit that referenced this pull request Sep 30, 2024
Updating scep package with changes up to
github.com/micromdm/scep@781f8042a79cabcf61a5e6c01affdbadcb785932
Fixes needed for NDES client for #21955 

Manually pulled in the recent changes. You can view the changes in the
remote like:
getvictor/scep@fleet...micromdm:scep:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants