Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory usage of software installers parsing #23596

Merged
merged 20 commits into from
Nov 12, 2024

Conversation

mna
Copy link
Member

@mna mna commented Nov 6, 2024

#20595

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality (smoke-tested adding/editing installers, and via fleetctl)

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 60.14493% with 55 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (eff1041) to head (22190b8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/fleet/software_installer.go 50.00% 14 Missing and 6 partials ⚠️
server/service/software_installers.go 26.66% 10 Missing and 1 partial ⚠️
ee/server/service/software_installers.go 79.16% 3 Missing and 2 partials ⚠️
pkg/file/file.go 60.00% 3 Missing and 1 partial ⚠️
pkg/file/xar.go 66.66% 2 Missing and 2 partials ⚠️
...md/osquery-perf/installer_cache/installer-cache.go 0.00% 3 Missing ⚠️
ee/server/service/maintained_apps.go 57.14% 2 Missing and 1 partial ⚠️
pkg/file/msi.go 76.92% 1 Missing and 2 partials ⚠️
pkg/file/pe.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23596      +/-   ##
==========================================
- Coverage   63.14%   63.13%   -0.01%     
==========================================
  Files        1557     1557              
  Lines      147617   147690      +73     
  Branches     3687     3703      +16     
==========================================
+ Hits        93210    93246      +36     
- Misses      47036    47063      +27     
- Partials     7371     7381      +10     
Flag Coverage Δ
backend 63.99% <60.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna marked this pull request as ready for review November 12, 2024 13:27
@mna mna requested a review from a team as a code owner November 12, 2024 13:27
Copy link
Contributor

@jahzielv jahzielv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for adding the benchmark test!

@mna mna merged commit c3ebce9 into main Nov 12, 2024
26 checks passed
@mna mna deleted the mna-20595-stream-software-installers branch November 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants