Cleaning up publish release and adding chart version increment #26535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgekarrv
had a problem deploying
to
Docker Hub
GitHub Actions
Error
georgekarrv
had a problem deploying
to
Docker Hub
GitHub Actions
Error
georgekarrv
commented
Feb 21, 2025
georgekarrv
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
georgekarrv
commented
Feb 21, 2025
| target_branch=$(echo $output | jq -r .baseRefName) | ||
| echo -n "$pr $state $commit $target_branch:" | ||
| if [[ "$state" != "MERGED" || "$target_branch" != "main" ]]; then | ||
| target_pr_branch=$(echo $output | jq -r .baseRefName) |
There was a problem hiding this comment.
this overloading was causing one of the issues where 'target_branch' was the rc-xxx branch but get's set back to 'main' here so just setting this to an explicit var to avoid that.
georgekarrv
commented
Feb 21, 2025
| Linux*) echo "$version_files" | xargs sed -i "s/$escaped_start_version/$target_milestone/g";; | ||
| Darwin*) echo "$version_files" | xargs sed -i '' "s/$escaped_start_version/$target_milestone/g";; | ||
| Linux*) echo "$version_files" | xargs sed -i "s/$escaped_start_version/$target_milestone/g"; | ||
| sed -i -E 's/(version: v[0-9]+\.[0-9]+\.)([0-9]+)/echo "\1$((\2+1))"/e' charts/fleet/Chart.yaml;; |
There was a problem hiding this comment.
This is what will increment the patch version of the chart. If there are chart changes the user will still need to manually change the version in the PR from a patch update to a minor update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #23680