Package hub prep (#2)

* update readme, remove bq and redshift from ci job * commenting out bigquery variable * adding comments * fix column quoting in integration tests' * pin dbt to our version * try using seed ref * revert to latest version and hardcode table name in variable * syntax fix for package name * typo * add in new column to seed * Updating CI config, readme * adding in release drafter for release management --------- Co-authored-by: jchen <jchen@fleetio.com>
fleetio · Feb 10, 2023 · b6fdb5b · b6fdb5b
1 parent d463de9
commit b6fdb5b
Show file tree

Hide file tree

Showing 6 changed files with 124 additions and 44 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -10,10 +10,16 @@ jobs:
     steps:
       - checkout
 
-      - run:
-          run: setup_creds
-          command: |
-            echo $BIGQUERY_SERVICE_ACCOUNT_JSON > ${HOME}/bigquery-service-key.json
+      # fleetio note:
+      # the section below was written when dbt labs owned the package and supported bigquery and redshift
+      # we don't have test environments for redshift and bigquery, but we wanted to keep this in case we can support it in the future
+      # we're working on setting up a snowflake service account to use for the snowflake test, but for now we'll only run the CI job for postgres
+
+      # - run:
+      #     run: setup_creds
+      #     command: |
+      #       echo $BIGQUERY_SERVICE_ACCOUNT_JSON > ${HOME}/bigquery-service-key.json
+
 
       - restore_cache:
           key: deps1-{{ .Branch }}
@@ -25,7 +31,7 @@ jobs:
             . dbt_venv/bin/activate
 
             pip install --upgrade pip setuptools
-            pip install --pre dbt-core dbt-postgres dbt-redshift dbt-snowflake dbt-bigquery
+            pip install --pre dbt-core dbt-postgres dbt-snowflake
 
             mkdir -p ~/.dbt
             cp integration_tests/ci/sample.profiles.yml ~/.dbt/profiles.yml
@@ -46,43 +52,43 @@ jobs:
             dbt --warn-error seed --target postgres
             dbt --warn-error run --target postgres --full-refresh
             dbt --warn-error run --target postgres
+      
+      # - run:
+      #     name: "Run Tests - Redshift"
+      #     command: |
+      #       . dbt_venv/bin/activate
+      #       echo `pwd`
+      #       cd integration_tests
+      #       dbt --warn-error deps
+      #       dbt --warn-error seed --target redshift
+      #       dbt --warn-error run --target redshift --full-refresh
+      #       dbt --warn-error run --target redshift
 
+      # - run:
+      #     name: "Run Tests - BigQuery"
+      #     environment:
+      #         BIGQUERY_SERVICE_KEY_PATH: "/home/circleci/bigquery-service-key.json"
 
-      - run:
-          name: "Run Tests - Redshift"
-          command: |
-            . dbt_venv/bin/activate
-            echo `pwd`
-            cd integration_tests
-            dbt --warn-error deps
-            dbt --warn-error seed --target redshift
-            dbt --warn-error run --target redshift --full-refresh
-            dbt --warn-error run --target redshift
+      #     command: |
+      #       . dbt_venv/bin/activate
+      #       echo `pwd`
+      #       cd integration_tests
+      #       dbt --warn-error deps
+      #       dbt --warn-error seed --target bigquery
+      #       dbt --warn-error run --target bigquery --full-refresh
+      #       dbt --warn-error run --target bigquery      
 
-      - run:
-          name: "Run Tests - Snowflake"
-          command: |
-            . dbt_venv/bin/activate
-            echo `pwd`
-            cd integration_tests
-            dbt --warn-error deps
-            dbt --warn-error seed --target snowflake
-            dbt --warn-error run --target snowflake --full-refresh
-            dbt --warn-error run --target snowflake
-
-      - run:
-          name: "Run Tests - BigQuery"
-          environment:
-              BIGQUERY_SERVICE_KEY_PATH: "/home/circleci/bigquery-service-key.json"
 
-          command: |
-            . dbt_venv/bin/activate
-            echo `pwd`
-            cd integration_tests
-            dbt --warn-error deps
-            dbt --warn-error seed --target bigquery
-            dbt --warn-error run --target bigquery --full-refresh
-            dbt --warn-error run --target bigquery
+      # - run:
+      #     name: "Run Tests - Snowflake"
+      #     command: |
+      #       . dbt_venv/bin/activate
+      #       echo `pwd`
+      #       cd integration_tests
+      #       dbt --warn-error deps
+      #       dbt --warn-error seed --target snowflake
+      #       dbt --warn-error run --target snowflake --full-refresh
+      #       dbt --warn-error run --target snowflake
 
       - save_cache:
           key: deps1-{{ .Branch }}

diff --git a/.github/release-drafter.yml b/.github/release-drafter.yml
@@ -0,0 +1,45 @@
+name-template: 'v$RESOLVED_VERSION'
+tag-template: 'v$RESOLVED_VERSION'
+template: |
+  # What's Changed
+
+  $CHANGES
+
+  **Full Changelog**: https://github.com/$OWNER/$REPOSITORY/compare/$PREVIOUS_TAG...v$RESOLVED_VERSION
+
+categories:
+  - title: '🚀 New Features'
+    labels:
+      - 'feature'
+      - 'enhancement'
+  - title: '🐛 Bug Fixes'
+    labels:
+      - 'fix'
+      - 'bugfix'
+      - 'bug'
+  - title: '🧰 Maintenance'
+    labels: 
+      - 'chore'
+      - 'docs'
+      - 'security'
+      - 'dependencies'
+
+version-resolver:
+  major:
+    labels:
+      - 'major'
+  minor:
+    labels:
+      - 'feature'
+      - 'enhancement'
+  patch:
+    labels:
+      - 'fix'
+      - 'bugfix'
+      - 'bug'
+      - 'dependencies'
+      - 'security'
+      - 'docs'
+      - 'chore'
+  default: patch
+
diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml
@@ -0,0 +1,29 @@
+name: Release Drafter
+
+on:
+  push:
+    branches:
+      - main
+
+permissions:
+  contents: read
+
+jobs:
+  update_release_draft:
+    permissions:
+      # write permission is required to create a github release
+      contents: write
+      # write permission is required for autolabeler
+      # otherwise, read permission is required at least
+      pull-requests: write
+    runs-on: ubuntu-latest
+    steps:
+
+      # Drafts your next Release notes as Pull Requests are merged into "main"
+      - uses: release-drafter/release-drafter@v5
+        # (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml
+        # with:
+        #   config-name: my-config.yml
+        #   disable-autolabeler: true
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-> ⛔🏚️ This package is no longer developed or maintained by dbt Labs. If you're interested in forking/adopting it, reach out in #package-ecosystem on dbt Slack.
+> ⛔🏚️ This package is not officially related to Segment and is maintained by [Fleetio](https://fleetio.com). CI jobs run on PRs will only test for postgres compatibility. We're working on setting up a service account to support tests for Snowflake. Please submit an issue for any bugs/feature requests related to Redshift or BigQuery and we'll figure out how to help!
 
 # dbt-segment
 This [dbt package](https://docs.getdbt.com/docs/package-management):
@@ -54,4 +54,4 @@ the package to run successfully.
 This package has been tested on Redshift, Snowflake, BigQuery, and Postgres.
 
 ### Contributing
-Additional contributions to this repo are very welcome! Check out [this post](https://discourse.getdbt.com/t/contributing-to-a-dbt-package/657) on the best workflow for contributing to a package. All PRs should only include functionality that is contained within all Segment deployments; no implementation-specific details should be included.
+Additional contributions to this repo are very welcome! Check out [this post](https://discourse.getdbt.com/t/contributing-to-a-dbt-package/657) on the best workflow for contributing to a package. All PRs should only include functionality that is contained within all Segment deployments; no implementation-specific details should be included. CI jobs run on PRs will only test for postgres compatibility. 
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -7,8 +7,8 @@ seed-paths: ["seeds"]
 profile: 'integration_tests'
 
 vars:
-  segment:
+  dbt_segment:
     segment_page_views_table: "{{ ref('example_segment_pages') }}"
 
 seeds:
-  +quote_columns: false
+  +quote_columns: "{{ true if target.type in ('redshift','postgres') else false }}"
diff --git a/integration_tests/seeds/example_segment_pages.csv b/integration_tests/seeds/example_segment_pages.csv
@@ -1,2 +1,2 @@
-id,anonymous_id,user_id,received_at,sent_at,timestamp,url,path,title,search,referrer,context_campaign_source,context_campaign_medium,context_campaign_name,context_campaign_term,context_campaign_content,context_ip,context_user_agent
-ajs-9527e97fc714abe02a23b3d24cf09a36,507f191e810c19729de860ea,97980cfea0067,2015-02-23 22:28:55,2015-02-23 22:28:55,2015-02-23 22:28:55,https://www.getdbt.com/,/product,Product,?name=ferret,https://www.google.com/,facebook,social,autumn_collection_2015,foo,bar,8.8.8.8,"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.115 Safari/537.36"
+id,anonymous_id,user_id,received_at,sent_at,timestamp,url,path,title,search,referrer,context_campaign_source,context_campaign_medium,context_campaign_name,context_campaign_term,context_campaign_content,context_ip,context_user_agent,context_campaign_type
+ajs-9527e97fc714abe02a23b3d24cf09a36,507f191e810c19729de860ea,97980cfea0067,2015-02-23 22:28:55,2015-02-23 22:28:55,2015-02-23 22:28:55,https://www.getdbt.com/,/product,Product,?name=ferret,https://www.google.com/,facebook,social,autumn_collection_2015,foo,bar,8.8.8.8,"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.115 Safari/537.36","typein"