Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material icon is shown instead of Cupertino icon if its name is the same #2580

Closed
InesaFitsner opened this issue Feb 8, 2024 · 0 comments · Fixed by #2581
Closed

Material icon is shown instead of Cupertino icon if its name is the same #2580

InesaFitsner opened this issue Feb 8, 2024 · 0 comments · Fixed by #2581
Assignees

Comments

@InesaFitsner
Copy link
Contributor

Description

ft.cupertino_icons.PERSON_2 has the same string value as ft.icons.PERSON_2. Flet always shows one person icon (ft.icons.PERSON_2).

Code example to reproduce the issue:

    cupertino_icons = [
        ft.cupertino_icons.PERSON,
        ft.cupertino_icons.PERSON_2,
        ft.cupertino_icons.PERSON_2_ALT,
        ft.cupertino_icons.PERSON_3,
        ft.cupertino_icons.PERSON_3_FILL,
    ]
    icons = [
        ft.icons.PERSON,
        ft.icons.PERSON_2,
        ft.icons.PERSON_2_OUTLINED,
        ft.icons.PERSON_3,
        ft.icons.PERSON_4,
        ft.icons.PERSON_4_OUTLINED,
    ]

    page.add(ft.Text("Cupertino Icons"))
    for icon in cupertino_icons:
        page.add(ft.TextButton(icon=icon, text=icon))

    page.add(ft.Text("Material Icons"))
    for icon in icons:
        page.add(ft.TextButton(icon=icon, text=icon))
FeodorFitsner added a commit that referenced this issue Feb 9, 2024
…the same (#2581)

* Fixed: Material icon is shown instead of Cupertino icon if its name is the same

Fix #2580

* ci/generate_material_icons_*.sh added
zrr1999 pushed a commit to zrr1999/flet that referenced this issue Jul 17, 2024
…the same (flet-dev#2581)

* Fixed: Material icon is shown instead of Cupertino icon if its name is the same

Fix flet-dev#2580

* ci/generate_material_icons_*.sh added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants