Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rive not updating #4582

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix Rive not updating #4582

merged 2 commits into from
Dec 16, 2024

Conversation

syleishere
Copy link
Contributor

@syleishere syleishere commented Dec 16, 2024

Description

Quick rive pubspec fix, there was no "^" on rive's pubspec line, so could break it on future flutter versions. I think without 0.13.20 it does break flutter 3.27+ if I remember right.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Summary by Sourcery

Bug Fixes:

  • Fix the Rive dependency version in the pubspec.yaml to ensure compatibility with future Flutter versions by using a caret (^) to allow for non-breaking updates.

@FeodorFitsner
Copy link
Contributor

Bumping to 0.13.20 is OK, but I'd remove ^ anyway. Going forward we want to pin Flet dependencies to a specific version and manually update their versions. There is always either some package "patch" update or Flutter release that breaks the packaging.

@FeodorFitsner FeodorFitsner merged commit 27ba3b5 into flet-dev:main Dec 16, 2024
1 of 2 checks passed
@FeodorFitsner FeodorFitsner added the bug Something isn't working label Jan 22, 2025
@FeodorFitsner FeodorFitsner added this to the Flet v0.26.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants