-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flet doctor
CLI command
#4803
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! It's awesome. Will have a look at it today and return to you asap. |
|
… permission and virtual envs
Thanks @ndonkoHenri I have solved the duplicate and print issues as well as adding some additional checks in the verbose option |
Great! Thanks for the changes @Gordon-Burns. Some other remarks:
|
@ndonkoHenri Picked this up over the weekend and have addressed feedback by removing the unnecessary characters. Also changed the check_vitrual_env as it did not account for someone using conda |
@ndonkoHenri Just wanted to check in if there are anymore changes required or if this request is good ? |
Re: "Flutter is not installed" on the last screenshot - in Flet 0.26.0 |
Hi @FeodorFitsner the issue asked for this to be included in the checks- but if you feel it's no longer needed I am happy to remove? |
Thanks. I think it could be safely removed. Flet does no longer rely on Flutter installed by the user, but uses its private install. |
Sure, I will pick this up over the weekend and push changes |
@FeodorFitsner , Thanks again for the feedback this has now been addressed and pushed |
Sorry @Gordon-Burns, got distracted/occupied by some other stuffs lately. I made some last modifications as you might have noticed: the admin privileges are non-important, and it's check has been removed. Your PR looks good to be merged - thanks again for picking this up! |
Thanks @ndonkoHenri no worries on removing the other function |
Description
Test Code
# Test code for the review of this PR
Type of change
Checklist
Screenshots
Additional details
Summary by Sourcery
New Features:
flet doctor
command to diagnose potential issues with the Flet environment.