-
Notifications
You must be signed in to change notification settings - Fork 585
feat: BottomAppBar.border_radius property
#5743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…or BottomAppBar properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a border_radius property to the BottomAppBar control, allowing developers to customize the corner rounding of the bottom app bar. The implementation also updates documentation formatting and error messages for consistency.
- Added
border_radiusproperty toBottomAppBarwith corresponding Python and Dart implementations - Updated
clip_behaviorto automatically default toANTI_ALIASwhen border radius is applied - Improved documentation strings across multiple properties for clarity and consistency
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/python/packages/flet/src/flet/controls/material/bottom_app_bar.py | Added border_radius property, updated property documentation, and modified clip_behavior default behavior |
| packages/flet/lib/src/controls/bottom_app_bar.dart | Implemented border radius rendering using ClipRRect wrapper with automatic clip behavior handling |
| sdk/python/examples/controls/bottom_app_bar/border_radius.py | Added example demonstrating the new border_radius property usage |
| sdk/python/packages/flet/docs/controls/bottomappbar.md | Added documentation section for custom border radius feature |
| sdk/python/packages/flet/src/flet/controls/material/floating_action_button.py | Standardized error message formatting in documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Raises: | ||
| ValueError: If [`highlight_elevation`][(c).] is negative. | ||
| ValueError:If it is less than `0`. |
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after colon. Should be 'ValueError: If' not 'ValueError:If'.
| ValueError:If it is less than `0`. | |
| ValueError: If it is less than `0`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
Deploying flet-docs with
|
| Latest commit: |
f6c4784
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13a5f35a.flet-docs.pages.dev |
| Branch Preview URL: | https://bottom-appbar-radius.flet-docs.pages.dev |
|
Example screenshot must be generated with integration test. See example here: |
Fix #4322
Example Code
Summary by Sourcery
Enable custom border radius on BottomAppBar by introducing a new property, updating rendering logic in both Python and Dart components, and enhancing documentation and default value descriptions.
New Features:
Enhancements:
Documentation: