Skip to content

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Dec 20, 2025

Summary by Sourcery

Fix view pop event handling in the reactive Flet app and adjust the sunflower example layout for safe display on devices with insets.

Bug Fixes:

  • Correct view pop event routing by ensuring the popped view is resolved from unwrapped views matching the event route.

Enhancements:

  • Wrap the sunflower example content in a SafeArea to avoid overlap with system UI on modern devices.

…ndling

The Sunflower example app now wraps its main content in a SafeArea for better layout on devices with notches or insets. Additionally, the Page control's before_event method refactors ViewPopEvent handling to correctly unwrap and match views by route.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

Set expand=True on the main Column widget in the Sunflower example to allow it to fill available space. This improves layout flexibility and ensures the UI adapts better to different screen sizes.
@cloudflare-workers-and-pages
Copy link

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93d0879
Status:⚡️  Build in progress...

View logs

@FeodorFitsner FeodorFitsner merged commit 2f3c533 into main Dec 20, 2025
7 of 9 checks passed
@FeodorFitsner FeodorFitsner deleted the routing-pop-fix branch December 20, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants