Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Detect a line containing only whitespace as a valid break between … #43

Merged
merged 1 commit into from
Oct 29, 2016

Conversation

jasedit
Copy link

@jasedit jasedit commented Sep 23, 2016

…metadata and the source.

Fixes #22

@fletcher
Copy link
Owner

Thanks for submitting! I'll look at it when I get some time.

@jasedit
Copy link
Author

jasedit commented Sep 25, 2016

Happy to pay back a little effort for a tool I appreciate using so much. :)

@jasedit jasedit changed the title FIX: Detect a line containg only whitespace as a valid break between … FIX: Detect a line containing only whitespace as a valid break between … Sep 25, 2016
@fletcher fletcher merged commit ea66626 into fletcher:develop Oct 29, 2016
@fletcher
Copy link
Owner

I merged this into the develop branch, and it doesn't seem to work properly. In my testing, it causes the Transclusion tests to fail. Specifically, it transcludes the metadata in addition to the body of the file.

What am I doing wrong?

@jasedit
Copy link
Author

jasedit commented Oct 29, 2016

It worked for me in my testing - I can investigate and see if I can spot what's happening. I've been running with this fix for awhile though, and haven't had it transcluding metadata that I've spotted.

@fletcher
Copy link
Owner

Pull the develop branch, and back up prior to my commit reverting the
pull request. Then compare it with the Transclusion.text test file.

F-

On 10/29/16 2:19 PM, Jason Ziglar wrote:

It worked for me in my testing - I can investigate and see if I can spot
what's happening. I've been running with this fix for awhile though, and
haven't had it transcluding metadata that I've spotted.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#43 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF8Kehqb1covpvV3UrpMxcxLrbyErZRks5q444cgaJpZM4KFUT3.

Fletcher T. Penney
fletcher@fletcherpenney.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants