FIXED: Use "command -v" instead of "which" #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of "which" is not standardized by POSIX. Some old implementations print their error messages to stdout instead of stderr, and don't return a nonzero exit code when they fail to find the given program. "command -v" on the other hand is in POSIX (optional in 2004 and required as of 2008).
|
I'll test. Not wedded to anything in particular, so whatever works best. |
|
I'll have to get to this later -- pull request was set to master instead of develop. |
Sorry, I wasn't aware you wanted PRs made against a different branch. I am still rather new to git, and have not yet encountered this situation, so I am not certain how to adjust my PR now so that it is against a different branch. |
|
Not your fault -- I thought I had set the default branch previously, but apparently I didn't?? When I tried to change the PR, it seemed to make it much more complicated, which made it more risky than I wanted to get into at the moment. Easier to just change the files. ;) Probably tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
whichis not standardized by POSIX. Some old implementations print their error messages to stdout instead of stderr, and don't return a nonzero exit code when they fail to find the given program.command -von the other hand is in POSIX (optional in 2004 and required as of 2008).