new notebooks and python scripts for quick start also fixed crm notebook #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-flex
requested review from
benflexcompute,
angranl-flex and
maciej-flexcompute
wiktor-flex
changed the title
There was a problem hiding this comment.
For this file:
- After code cell 6, "Another option to create a project is to use a file of your choice by using:"
- After code cell 15, "Finally we will take a look at how forces changed throughout the calculation of the simulation."
- Last Markdown block: visity -> visit
General comments for the other notebooks:
- Please also check other grammar errors.
- When plotting the results using, for instance,
cfl.plot(x='pseudo_step', y=["0_NavierStokes_cfl", "1_SpalartAllmaras_cfl"]), can you also show how to get the available keys/column names for setting up x and y here? - Can you also use
project.print_project_tree()to print out the project tree after the case is finished. Maybe also explain that the asset can be accessed using the shortID shown in the printed tree? For example, case = project.get_case(asset_id=)
There was a problem hiding this comment.
- In the "post processing" markdown block, ran -> run
- Do we still need to keep the complete code section at the end? I think we already have the complete code in the separate python script. Also, the other notebooks do not have this section.
There was a problem hiding this comment.
In "Simulation parameters" markdown block: paramas -> params
|
On hold until there is a decision as to what to do with the examples included here after the documentation changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added jupyter notebooks and python scripts for quick start:
Corrected the 2D CRM notebook