Disabled unnecessary assertions #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose remap functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most index remapping functions from indexgenerator.cpp operate on bitwise equality of vertices and perform remap index-by-index without assumptions about mesh primitives. Since we were using these functions for optimizing line-primitive meshes for the STEP file importer I have removed
index_count % 3 ==0assertions for relevant remapping functions (ones without assumption about buffer topology, so functions likemeshopt_generateAdjacencyIndexBufferstill have that assertion) which makes them automatically work for removing duplicate geometry for other mesh topologies.