-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Docs upgrades throughout 📈 #1420
Conversation
f7b5514
to
86d1e3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daquinteroflex I think this really improves things. Just a few minor comments.
one thing I fogot to mention: I think it's nice that we have some explanation of how to get to 2.6 if the link is broken. But is there a way to insert this information into a custom 404 page? (page not found. If you were trying to switch from an older version to 2.6, the link may have changed, please navigate from the main page). |
Yep so the 404 is in my list in the #1148 but will get to that in another PR |
86d1e3d
to
3f52e8f
Compare
3f52e8f
to
898cf7a
Compare
Will be probably ready to merge when these changes build btw (should be as just updating submodule) @tylerflex , the next set of docs upgrades will come in the next PR including the 404 if that sounds good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sounds good to me, feel free to merge whenever the build looks good.
Includes: