Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default td.ModeSpec in mode monitors #2058

Open
wants to merge 116 commits into
base: pre/2.8
Choose a base branch
from

Conversation

yaugenst-flex
Copy link
Contributor

@yaugenst-flex yaugenst-flex commented Nov 6, 2024

How do we feel about this? 😄

github-actions bot and others added 30 commits August 7, 2024 12:03
added validator to error out Bloch boundaries in along 0-dim in 2D simulations
yaugenst-flex and others added 24 commits October 24, 2024 18:02
* Polygon triangulation supports collinear vertices

* Improve docstring and initialization

Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Related to:

- flexcompute/tidy3d-core#751

- flexcompute/tidy3d-core#750

Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
@yaugenst-flex yaugenst-flex self-assigned this Nov 6, 2024
@momchil-flex momchil-flex changed the base branch from develop to pre/2.8 November 7, 2024 09:46
@momchil-flex
Copy link
Collaborator

I'm ok with this but would rather put it in 2.8. But simply changing the base makes a mess, could you try cherry-picking your commit?

@momchil-flex momchil-flex added the 2.8 will go into version 2.8.* label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 will go into version 2.8.*
Projects
None yet
Development

Successfully merging this pull request may close these issues.