Removing the user-defined source phase from normalization #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momchil-flex
force-pushed
the
momchil/normalization
branch
from
39764e7 to
532e948
Compare
|
What is meant by user-defined phase? |
|
Ok I think I understand, basically if we normalize including Other option would be to include the user-defined phase back into the adjoint calculation, since we can always apply it to the frequency-domain, complex-valued fields after the fact. |
|
Correct. I think this should be done as here, because it is generally strange that the phase has no effect, and I don't see a downside. |
tylerflex
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to make the simple adjoint test pass. See also the comment in the changed file.