Reorganizing of ModeSolver and ModeSolverData #260
Conversation
tidy3d/plugins/mode/mode_solver.py
Outdated
| ---------- | ||
| mode_solver : :class:`.ModeSolver` | ||
| Original mode solver instance. | ||
| data_dict : Dict[str, :class:`.AbstractModeData`] |
There was a problem hiding this comment.
maybe here we just put the same type as line 44 with the union.
| "mode_spec": self.mode_spec, | ||
| } | ||
| for name, obj in json_dict.items(): | ||
| Tidy3dData.save_string(handle, name, obj.json()) |
There was a problem hiding this comment.
note this is not storing 'Infinity' as a string.
| "mode_spec": ModeSpec, | ||
| } | ||
| obj_dict = {} | ||
| for name, obj in json_dict.items(): |
| ModeSource | ||
| Modal source containing specification in ``mode``. | ||
| :class:`.ModeSource` | ||
| Mode source with specifications taken from the ModeSolver instance and the method |
| ---------- | ||
| mode_spec : :class:`ModeSpec` | ||
| :class:`ModeSpec` object containing specifications of mode. | ||
| freqs : List[float] |
There was a problem hiding this comment.
these freqs are all stored in the ModeSolver? So do we want to:
a) keep it the way it is
b) use self.freqs here?
b) use self.freqs if freqs is None or something fancier like this?
There was a problem hiding this comment.
Good question, I kinda like keeping it the way it is because it makes sure the user knows what's happening and passes the frequencies they want, or in general knows that it's possible to export a monitor with different (e.g. more) frequencies that they used in the solver. So I'm between a) or c), but like a).
There was a problem hiding this comment.
ok let's keep it (a) then, that's fine with me.
| ModeMonitor | ||
| Monitor that measures modes specified by ``mode_spec`` on ``plane`` at ``freqs``. | ||
| :class:`.ModeMonitor` | ||
| Mode monitor with specifications taken from the ModeSolver instance and the method |
Some shared code with SimulationData w.r.t. plotting fields SimulationData.plot_field now doesn't need x/y/z/ for a 2D monitor
Notes: