Skip to content

uses bounding box and simpler intersection checks in filter_structure #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2022
Merged

uses bounding box and simpler intersection checks in filter_structure #293

merged 1 commit into from
Apr 5, 2022

Conversation

tylerflex
Copy link
Collaborator

also changed the large number constant, which was causing issues as float32(1e20)
much faster plotting

@tylerflex tylerflex requested a review from momchil-flex April 5, 2022 23:04
@tylerflex tylerflex merged commit 0c700ba into develop Apr 5, 2022
@tylerflex tylerflex deleted the tyler/faster_filtering branch April 5, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momchil-flex momchil-flex momchil-flex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerflex @momchil-flex