separated plotly from rest of requirements.txt #326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package Structure
restructured requirements setup:
core.txt
contains the core packages.plotly.txt
contains the packages needed to run plotly (core + plotly imports)dev.txt
contains the packages needed to run the tests (core + plotly + testing imports)Note: the old import structure didnt work with this because it would try to import plotly and dash any time
tidy3d
was imported. So now, to import plotly stuff, need to doPackaging
setup.py
imports theinstall_requires
fromrequirements.txt
, which only containscommon.txt
.setup.py
also imports the contents ofplotly.txt
and adds these as anextra_requires
.This means when someone is pip installing tidy3d, they can do
pip install tidy3d
(basic packages)pip install "tidy3d[plotly]"
(basic packages + plotly).and if local installation, this command looks like
pip install -e ".[plotly]"
if you want to install the dev requirements, for testing, etc. just add
pip install -r requirements/dev.txt