Skip to content

Conversation

tylerflex
Copy link
Collaborator

requested by user.

@tylerflex tylerflex requested a review from shashwat-sh April 19, 2022 20:55
@tylerflex
Copy link
Collaborator Author

I tested this on VizSimulation.ipynb notebook with all combinations of .plot() vs .plot_eps() and values of source_alpha and monitor_alpha.

@tylerflex tylerflex linked an issue Apr 19, 2022 that may be closed by this pull request
Copy link
Contributor

@shashwat-sh shashwat-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

z : float = None
position of plane in z direction, only one of x, y, z must be specified to define plane.
source_alpha : float = None
Opacity of the sources. If ``None``, uses to Tidy3d default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uses Tidy3D default"? (Also next line)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, just saw these. thanks. will fix

Opacity of the structures being plotted.
Defaults to the structure default alpha.
source_alpha : float = None
Opacity of the sources. If ``None``, uses to Tidy3d default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uses Tidy3D default"? (Also next line)

@tylerflex tylerflex merged commit 1dd67fc into develop Apr 20, 2022
@tylerflex tylerflex deleted the tyler/alpha_source_monitor branch May 31, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set alpha for sources and monitors in .plot
2 participants