Skip to content

catch validation for grid spec supplied as grid size #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

catch validation for grid spec supplied as grid size #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tidy3d/components/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# pylint: disable=too-many-lines, too-many-arguments
""" Container holding all information about simulation and its components"""
from typing import Dict, Tuple, List, Set
from typing import Dict, Tuple, List, Set, Union
from functools import lru_cache

import pydantic
Expand Down Expand Up @@ -101,7 +101,7 @@ class Simulation(Box): # pylint:disable=too-many-public-methods
units=SECOND,
)

grid_size: Tuple[GridSize, GridSize, GridSize] = pydantic.Field(
grid_size: Union[GridSpec, Tuple[GridSize, GridSize, GridSize]] = pydantic.Field(
None,
title="Grid Size",
description="NOTE: 'grid_size' has been replaced by 'grid_spec'.",
Expand Down