Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Halfspace through main [collision/distance/continuous collision] interface #60

Merged
merged 5 commits into from
May 7, 2015

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Apr 9, 2015

This pull request enables to use Halfspace through the main interface. FCL contains Halfspace shape and necessary algorithms for [collision/distance/continuous collision], but it couldn't be used through the main interface collide(~) because it's not registered to the corresponding function matrices. Here is an example code that prints warning messages and doesn't compute collision result for Halfspace.

Cylinder s(5, 10);
Halfspace hs(Vec3f(1, 0, 0), 0);
Transform3f tf1;
Transform3f tf2;

CollisionRequest request;
CollisionResult result;

// Following code prints warning message:
// Warning: collision function between node type 13 and node type 16 is not supported
collide(&s, tf1, &hs, tf2, request, result);

This PR resolves #57.

@jslee02 jslee02 changed the title Support Halfspace Support Halfspace through main [collision/distance/continuous collision] interface Apr 9, 2015
@jslee02
Copy link
Member Author

jslee02 commented Apr 30, 2015

It's fixed by 40a0caf.

@scpeters
Copy link
Contributor

scpeters commented May 7, 2015

👍

@scpeters
Copy link
Contributor

scpeters commented May 7, 2015

I didn't like the github diff colorization, so I used meld on my local machine, and it was much easier to see the changes. Nice work on generalizing the tests.

@jslee02
Copy link
Member Author

jslee02 commented May 7, 2015

Agreed, it's hard to see the changes in here especially when the changes are more than 1k lines. The tests are still long, maybe I could shorten more once I get more used to Boost Test Library.

I'll wait another one day for further comments.

jslee02 added a commit that referenced this pull request May 7, 2015
Support Halfspace through main [collision/distance/continuous collision] interface
@jslee02 jslee02 merged commit ad7a58c into flexible-collision-library:master May 7, 2015
@jslee02 jslee02 deleted the halfspace branch October 21, 2015 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Halfspace is not supported by main collision interface
2 participants