Merge pull request #6052 from flexion/5511-remove-isqc

5511: remove isQC from work items
flexion · Jul 31, 2020 · c422fe7 · c422fe7
2 parents f7a7030 + e290e22
commit c422fe7
Show file tree

Hide file tree

Showing 83 changed files with 56 additions and 555 deletions.
diff --git a/docs/entities/WorkItem.md b/docs/entities/WorkItem.md
@@ -167,10 +167,6 @@
       type: "boolean"
       flags: 
         presence: "optional"
-    isQC: 
-      type: "boolean"
-      flags: 
-        presence: "required"
     isRead: 
       type: "boolean"
       flags: 

diff --git a/shared/src/business/entities/Document.js b/shared/src/business/entities/Document.js
@@ -590,7 +590,7 @@ Document.prototype.setAsProcessingStatusAsCompleted = function () {
 };
 
 Document.prototype.getQCWorkItem = function () {
-  return this.workItems.find(workItem => workItem.isQC === true);
+  return this.workItems[0];
 };
 
 Document.prototype.isAutoServed = function () {

diff --git a/shared/src/business/entities/Document.test.js b/shared/src/business/entities/Document.test.js
@@ -200,7 +200,6 @@ describe('Document entity', () => {
           caseTitle: 'Johnny Joe Jacobson',
           docketNumber: '101-18',
           document: {},
-          isQC: true,
           section: 'petitions',
           sentBy: 'bob',
         },
@@ -1473,7 +1472,7 @@ describe('Document entity', () => {
   });
 
   describe('getQCWorkItem', () => {
-    it('returns the first workItem with isQC = true', () => {
+    it('returns the first workItem', () => {
       const document = new Document(
         {
           ...A_VALID_DOCUMENT,
@@ -1485,48 +1484,24 @@ describe('Document entity', () => {
               caseTitle: 'Johnny Joe Jacobson',
               docketNumber: '101-18',
               document: {},
-              isQC: false,
               sentBy: 'bill',
               workItemId: 'dda4acce-7b0f-40e2-b5a7-261b5c0dee28',
             },
-            {
-              assigneeId: '8b4cd447-6278-461b-b62b-d9e357eea62c',
-              assigneeName: 'bob',
-              caseStatus: CASE_STATUS_TYPES.NEW,
-              caseTitle: 'Johnny Joe Jacobson',
-              docketNumber: '101-18',
-              document: {},
-              isQC: true,
-              sentBy: 'bob',
-              workItemId: '062d334b-7589-4b28-9dcf-72989574b7a7',
-            },
           ],
         },
         { applicationContext },
       );
 
       expect(document.getQCWorkItem()).toMatchObject({
-        workItemId: '062d334b-7589-4b28-9dcf-72989574b7a7',
+        workItemId: 'dda4acce-7b0f-40e2-b5a7-261b5c0dee28',
       });
     });
 
-    it('returns undefined if there is no QC work item', () => {
+    it('returns undefined if there is no work item', () => {
       const document = new Document(
         {
           ...A_VALID_DOCUMENT,
-          workItems: [
-            {
-              assigneeId: '49b4789b-3c90-4940-946c-95a700d5a501',
-              assigneeName: 'bill',
-              caseStatus: CASE_STATUS_TYPES.NEW,
-              caseTitle: 'Johnny Joe Jacobson',
-              docketNumber: '101-18',
-              document: {},
-              isQC: false,
-              sentBy: 'bill',
-              workItemId: 'dda4acce-7b0f-40e2-b5a7-261b5c0dee28',
-            },
-          ],
+          workItems: [],
         },
         { applicationContext },
       );

diff --git a/shared/src/business/entities/WorkItem.js b/shared/src/business/entities/WorkItem.js
@@ -47,7 +47,6 @@ function WorkItem(rawWorkItem, { applicationContext }) {
   this.highPriority = rawWorkItem.highPriority;
   this.inProgress = rawWorkItem.inProgress;
   this.isInitializeCase = rawWorkItem.isInitializeCase;
-  this.isQC = rawWorkItem.isQC;
   this.isRead = rawWorkItem.isRead;
   this.section = rawWorkItem.section;
   this.sentBy = rawWorkItem.sentBy;
@@ -91,7 +90,6 @@ joiValidationDecorator(
     highPriority: joi.boolean().optional(),
     inProgress: joi.boolean().optional(),
     isInitializeCase: joi.boolean().optional(),
-    isQC: joi.boolean().required(),
     isRead: joi.boolean().optional(),
     section: joi
       .string()
@@ -118,11 +116,6 @@ joiValidationDecorator(
   }),
 );
 
-WorkItem.prototype.setAsInternal = function () {
-  this.isQC = false;
-  return this;
-};
-
 /**
  * Assign to a user
  *

diff --git a/shared/src/business/entities/WorkItem.test.js b/shared/src/business/entities/WorkItem.test.js
@@ -21,7 +21,6 @@ describe('WorkItem', () => {
           docketNumber: '101-18',
           docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
           document: {},
-          isQC: true,
           section: 'docket',
           sentBy: 'bob',
         },
@@ -39,7 +38,6 @@ describe('WorkItem', () => {
           docketNumber: '101-18',
           docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
           document: {},
-          isQC: true,
           section: 'docket',
           sentBy: 'bob',
         },
@@ -50,26 +48,6 @@ describe('WorkItem', () => {
       expect(workItem.isValid()).toBeTruthy();
     });
 
-    it('Returns a reference to a valid workItem when calling setAsInternal', () => {
-      const workItem = new WorkItem(
-        {
-          assigneeId: '8b4cd447-6278-461b-b62b-d9e357eea62c',
-          assigneeName: 'bob',
-          caseTitle: 'Johnny Joe Jacobson',
-          docketNumber: '101-18',
-          docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
-          document: {},
-          isQC: true,
-          section: 'docket',
-          sentBy: 'bob',
-        },
-        { applicationContext },
-      );
-      const updatedWorkItem = workItem.setAsInternal();
-      expect(updatedWorkItem.isQC).toEqual(false);
-      expect(updatedWorkItem.isValid()).toBeTruthy();
-    });
-
     it('Update a valid workitem with a workItemId', () => {
       const workItem = new WorkItem(
         {
@@ -80,7 +58,6 @@ describe('WorkItem', () => {
           docketNumber: '101-18',
           docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
           document: {},
-          isQC: true,
           section: 'docket',
           sentBy: 'bob',
           workItemId: 'c6b81f4d-1e47-423a-8caf-6d2fdc3d3859',
@@ -100,7 +77,6 @@ describe('WorkItem', () => {
           docketNumber: '101-18',
           docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
           document: {},
-          isQC: true,
           isRead: true,
           section: 'docket',
           sentBy: 'bob',
@@ -122,7 +98,6 @@ describe('WorkItem', () => {
         docketNumber: '101-18',
         docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
         document: {},
-        isQC: true,
         sentBy: 'bob',
       },
       { applicationContext },

diff --git a/shared/src/business/entities/cases/Case.test.js b/shared/src/business/entities/cases/Case.test.js
@@ -1551,7 +1551,6 @@ describe('Case entity', () => {
           caseTitle: 'Johnny Joe Jacobson',
           docketNumber: '101-18',
           document: {},
-          isQC: true,
           sentBy: 'bob',
         },
         { applicationContext },
@@ -1567,7 +1566,6 @@ describe('Case entity', () => {
           caseTitle: 'Johnny Joe Jacobson',
           docketNumber: '101-18',
           document: {},
-          isQC: true,
           sentBy: 'bob',
         },
       ]);

diff --git a/shared/src/business/useCases/courtIssuedDocument/serveCourtIssuedDocumentInteractor.test.js b/shared/src/business/useCases/courtIssuedDocument/serveCourtIssuedDocumentInteractor.test.js
@@ -44,7 +44,6 @@ describe('serveCourtIssuedDocumentInteractor', () => {
 
   const mockWorkItem = {
     docketNumber: '101-20',
-    isQC: true,
     section: DOCKET_SECTION,
     sentBy: mockUser.name,
     sentByUserId: mockUser.userId,

diff --git a/shared/src/business/useCases/createCaseFromPaperInteractor.js b/shared/src/business/useCases/createCaseFromPaperInteractor.js
@@ -31,7 +31,6 @@ const addPetitionDocumentWithWorkItemToCase = ({
         createdAt: documentEntity.createdAt,
       },
       isInitializeCase: true,
-      isQC: true,
       section: user.section,
       sentBy: user.name,
       sentBySection: user.section,

diff --git a/shared/src/business/useCases/createCaseInteractor.js b/shared/src/business/useCases/createCaseInteractor.js
@@ -36,7 +36,6 @@ const addPetitionDocumentToCase = ({
         createdAt: documentEntity.createdAt,
       },
       isInitializeCase: true,
-      isQC: true,
       section: PETITIONS_SECTION,
       sentBy: user.name,
       sentByUserId: user.userId,

diff --git a/shared/src/business/useCases/docketEntry/fileCourtIssuedDocketEntryInteractor.js b/shared/src/business/useCases/docketEntry/fileCourtIssuedDocketEntryInteractor.js
@@ -107,7 +107,6 @@ exports.fileCourtIssuedDocketEntryInteractor = async ({
       },
       hideFromPendingMessages: true,
       inProgress: true,
-      isQC: true,
       section: DOCKET_SECTION,
       sentBy: user.name,
       sentByUserId: user.userId,

diff --git a/shared/src/business/useCases/docketEntry/fileDocketEntryInteractor.js b/shared/src/business/useCases/docketEntry/fileDocketEntryInteractor.js
@@ -100,7 +100,6 @@ exports.fileDocketEntryInteractor = async ({
             createdAt: documentEntity.createdAt,
           },
           inProgress: isSavingForLater,
-          isQC: true,
           isRead: user.role !== ROLES.privatePractitioner,
           section: DOCKET_SECTION,
           sentBy: user.name,

diff --git a/shared/src/business/useCases/docketEntry/updateCourtIssuedDocketEntryInteractor.test.js b/shared/src/business/useCases/docketEntry/updateCourtIssuedDocketEntryInteractor.test.js
@@ -84,7 +84,6 @@ describe('updateCourtIssuedDocketEntryInteractor', () => {
               docketNumber: '101-18',
               docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
               document: {},
-              isQC: true,
               messages: [],
               section: 'docket',
               sentBy: 'bob',
@@ -106,7 +105,6 @@ describe('updateCourtIssuedDocketEntryInteractor', () => {
               docketNumber: '101-18',
               docketNumberSuffix: DOCKET_NUMBER_SUFFIXES.SMALL,
               document: {},
-              isQC: true,
               messages: [],
               section: 'docket',
               sentBy: 'bob',

diff --git a/shared/src/business/useCases/docketEntry/updateDocketEntryInteractor.js b/shared/src/business/useCases/docketEntry/updateDocketEntryInteractor.js
@@ -144,7 +144,6 @@ exports.updateDocketEntryInteractor = async ({
           createdAt: documentEntity.createdAt,
         },
         inProgress: isSavingForLater,
-        isQC: true,
         section: DOCKET_SECTION,
         sentBy: user.userId,
       });

diff --git a/shared/src/business/useCases/docketEntry/updateDocketEntryInteractor.test.js b/shared/src/business/useCases/docketEntry/updateDocketEntryInteractor.test.js
@@ -22,7 +22,6 @@ describe('updateDocketEntryInteractor', () => {
       eventCode: 'A',
       userId: 'c54ba5a9-b37b-479d-9201-067ec6e335bb',
     },
-    isQC: true,
     section: 'docket',
     sentBy: 'c54ba5a9-b37b-479d-9201-067ec6e335bb',
     updatedAt: new Date().toISOString(),

diff --git a/shared/src/business/useCases/editDocketEntry/completeDocketEntryQCInteractor.test.js b/shared/src/business/useCases/editDocketEntry/completeDocketEntryQCInteractor.test.js
@@ -36,7 +36,6 @@ describe('completeDocketEntryQCInteractor', () => {
         filedBy: 'Test Petitioner',
         userId: 'c54ba5a9-b37b-479d-9201-067ec6e335bb',
       },
-      isQC: true,
       section: 'docket',
       sentBy: 'Test User',
       sentByUserId: 'c54ba5a9-b37b-479d-9201-067ec6e335bb',

diff --git a/...d/src/business/useCases/externalDocument/fileExternalDocumentForConsolidatedInteractor.js b/...d/src/business/useCases/externalDocument/fileExternalDocumentForConsolidatedInteractor.js
@@ -184,7 +184,6 @@ exports.fileExternalDocumentForConsolidatedInteractor = async ({
                   ...documentEntity.toRawObject(),
                   createdAt: documentEntity.createdAt,
                 },
-                isQC: true,
                 section: DOCKET_SECTION,
                 sentBy: user.name,
                 sentByUserId: user.userId,

diff --git a/shared/src/business/useCases/externalDocument/fileExternalDocumentInteractor.js b/shared/src/business/useCases/externalDocument/fileExternalDocumentInteractor.js
@@ -153,7 +153,6 @@ exports.fileExternalDocumentInteractor = async ({
             createdAt: documentEntity.createdAt,
           },
           highPriority: highPriorityWorkItem,
-          isQC: true,
           section: DOCKET_SECTION,
           sentBy: user.name,
           sentByUserId: user.userId,

diff --git a/shared/src/business/useCases/getNotificationsInteractor.js b/shared/src/business/useCases/getNotificationsInteractor.js
@@ -6,13 +6,6 @@
  * @returns {object} inbox unread message counts for the individual and section inboxes
  */
 exports.getNotificationsInteractor = async ({ applicationContext }) => {
-  const messagesInbox = await applicationContext
-    .getPersistenceGateway()
-    .getInboxMessagesForUser({
-      applicationContext,
-      userId: applicationContext.getCurrentUser().userId,
-    });
-
   const documentQCInbox = await applicationContext
     .getPersistenceGateway()
     .getDocumentQCInboxForUser({
@@ -21,7 +14,6 @@ exports.getNotificationsInteractor = async ({ applicationContext }) => {
     });
 
   return {
-    myInboxUnreadCount: messagesInbox.filter(item => !item.isRead).length,
     qcUnreadCount: documentQCInbox.filter(item => !item.isRead).length,
   };
 };
diff --git a/shared/src/business/useCases/getNotificationsInteractor.test.js b/shared/src/business/useCases/getNotificationsInteractor.test.js
@@ -10,75 +10,46 @@ describe('getNotificationsInteractor', () => {
       .getPersistenceGateway()
       .getDocumentQCInboxForUser.mockReturnValue([
         {
-          isQC: false,
           isRead: true,
         },
       ]);
 
-    applicationContext
-      .getPersistenceGateway()
-      .getInboxMessagesForUser.mockReturnValue([
-        {
-          isQC: false,
-          isRead: false,
-        },
-      ]);
-
     const result = await getNotificationsInteractor({
       applicationContext,
       userId: 'docketclerk',
     });
-    expect(result).toEqual({ myInboxUnreadCount: 1, qcUnreadCount: 0 });
+    expect(result).toEqual({ qcUnreadCount: 0 });
   });
 
   it('returns an unread count for qc messages', async () => {
     applicationContext
       .getPersistenceGateway()
       .getDocumentQCInboxForUser.mockReturnValue([
         {
-          isQC: false,
           isRead: false,
         },
       ]);
 
-    applicationContext
-      .getPersistenceGateway()
-      .getInboxMessagesForUser.mockReturnValue([
-        {
-          isQC: true,
-          isRead: true,
-        },
-      ]);
-
     const result = await getNotificationsInteractor({
       applicationContext,
       userId: 'docketclerk',
     });
-    expect(result).toEqual({ myInboxUnreadCount: 0, qcUnreadCount: 1 });
+    expect(result).toEqual({ qcUnreadCount: 1 });
   });
 
   it('returns an accurate unread count for legacy items marked complete', async () => {
     applicationContext
       .getPersistenceGateway()
       .getDocumentQCInboxForUser.mockReturnValue([
         {
-          isQC: false,
           isRead: true,
         },
       ]);
 
-    applicationContext
-      .getPersistenceGateway()
-      .getInboxMessagesForUser.mockReturnValue([
-        {
-          isQC: false,
-          isRead: true,
-        },
-      ]);
     const result = await getNotificationsInteractor({
       applicationContext,
       userId: 'docketclerk',
     });
-    expect(result).toEqual({ myInboxUnreadCount: 0, qcUnreadCount: 0 });
+    expect(result).toEqual({ qcUnreadCount: 0 });
   });
 });