Merge pull request #1118 from flexion/task/962_sent_box

962 - Prevent Outbox Entries
flexion · Mar 15, 2019 · d987290 · d987290
2 parents 534b815 + 5cdadcf
commit d987290
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 17 deletions.
diff --git a/shared/src/business/useCases/workitems/completeWorkItemInteractor.js b/shared/src/business/useCases/workitems/completeWorkItemInteractor.js
@@ -41,6 +41,7 @@ exports.completeWorkItem = async ({
 
   await applicationContext.getPersistenceGateway().saveWorkItem({
     applicationContext,
+    createOutboxEntries: true,
     workItemToSave: completedWorkItem,
   });
 

diff --git a/shared/src/business/useCases/workitems/forwardWorkItemInteractor.js b/shared/src/business/useCases/workitems/forwardWorkItemInteractor.js
@@ -62,6 +62,7 @@ exports.forwardWorkItem = async ({
 
   return applicationContext.getPersistenceGateway().saveWorkItem({
     applicationContext,
+    createOutboxEntries: true,
     workItemToSave: workItemToForward.validate().toRawObject(),
   });
 };
diff --git a/shared/src/persistence/dynamo/workitems/saveWorkItem.js b/shared/src/persistence/dynamo/workitems/saveWorkItem.js
@@ -5,7 +5,11 @@ const { stripInternalKeys } = require('../../dynamo/helpers/stripInternalKeys');
 const { getCaseByCaseId } = require('../cases/getCaseByCaseId');
 const { saveVersionedCase } = require('../cases/saveCase');
 
-exports.saveWorkItem = async ({ workItemToSave, applicationContext }) => {
+exports.saveWorkItem = async ({
+  workItemToSave,
+  createOutboxEntries,
+  applicationContext,
+}) => {
   const user = applicationContext.getCurrentUser();
 
   const existingWorkItem = await getWorkItemById({
@@ -40,23 +44,25 @@ exports.saveWorkItem = async ({ workItemToSave, applicationContext }) => {
     existingVersion: (caseToUpdate || {}).currentVersion,
   });
 
-  await client.put({
-    applicationContext,
-    Item: {
-      pk: `${user.userId}|outbox`,
-      sk: new Date().toISOString(),
-      ...workItemToSave,
-    },
-  });
+  if (createOutboxEntries) {
+    await client.put({
+      applicationContext,
+      Item: {
+        pk: `${user.userId}|outbox`,
+        sk: new Date().toISOString(),
+        ...workItemToSave,
+      },
+    });
 
-  await client.put({
-    applicationContext,
-    Item: {
-      pk: `${user.section}|outbox`,
-      sk: new Date().toISOString(),
-      ...workItemToSave,
-    },
-  });
+    await client.put({
+      applicationContext,
+      Item: {
+        pk: `${user.section}|outbox`,
+        sk: new Date().toISOString(),
+        ...workItemToSave,
+      },
+    });
+  }
 
   const workItem = await client.put({
     applicationContext,