Merge pull request #369 from flexion/111_add_bar_number

add bar number to view and seed
flexion · Dec 13, 2018 · fbffa64 · fbffa64
2 parents 1537f3c + 0a4a4f6
commit fbffa64
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 4 deletions.
diff --git a/efcms-service/storage/fixtures/efcms.json b/efcms-service/storage/fixtures/efcms.json
@@ -90,7 +90,8 @@
       "userId": "respondent",
       "respondentId": "respondent",
       "email": "testrespondent@example.com",
-      "token": "respondent"
+      "token": "respondent",
+      "barNumber": "IR1228"
     },
     "userId": "taxpayer",
     "irsSendDate": "2018-12-12T23:32:48.416Z",

diff --git a/web-client/src/presenter/computeds/formattedCaseDetail.js b/web-client/src/presenter/computeds/formattedCaseDetail.js
@@ -12,7 +12,10 @@ const formatCase = (caseDetail, form) => {
   const result = _.cloneDeep(caseDetail);
 
   if (result.documents) result.documents.map(formatDocument);
-
+  if (result.respondent)
+    result.respondent.formattedName = `${result.respondent.name} ${
+      result.respondent.barNumber
+    }`;
   result.createdAtFormatted = moment(result.createdAt).format('L');
   result.irsDateFormatted = moment(result.irsDate).format('L LT');
   result.payGovDateFormatted = moment(result.payGovDate).format('L');
@@ -29,6 +32,7 @@ const formatCase = (caseDetail, form) => {
 
   result.status =
     result.status === 'general' ? 'general docket' : result.status;
+
   return result;
 };
 

diff --git a/web-client/src/tests/computeds.test.js b/web-client/src/tests/computeds.test.js
@@ -27,6 +27,15 @@ describe('formatted case details computed', () => {
     });
     expect(result[0].irsDateFormatted).toContain('11/21/2018');
   });
+
+  it('formats the respondent name to include barnumber', () => {
+    const result = runCompute(formattedCases, {
+      state: {
+        cases: [{ respondent: { name: 'test', barNumber: '123' } }],
+      },
+    });
+    expect(result[0].respondent.formattedName).toContain('test 123');
+  });
 });
 
 describe('formatted search parameters computed', () => {

diff --git a/web-client/src/views/PartyInformation.jsx b/web-client/src/views/PartyInformation.jsx
@@ -5,7 +5,7 @@ import { state } from 'cerebral';
 
 export default connect(
   {
-    caseDetail: state.caseDetail,
+    caseDetail: state.formattedCaseDetail,
   },
   function PartyInformation({ caseDetail }) {
     return (
@@ -42,7 +42,7 @@ export default connect(
               <React.Fragment>
                 <h4>Respondent</h4>
                 <address>
-                  <p>{caseDetail.respondent.name}</p>
+                  <p>{caseDetail.respondent.formattedName}</p>
                   <p>
                     <span className="address-line">
                       {caseDetail.respondent.addressLine1}