Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petitioner: Enter Case Metadata (2.5) #402

Closed
69 of 70 tasks
JessicaMarine opened this issue Dec 18, 2018 · 13 comments
Closed
69 of 70 tasks

Petitioner: Enter Case Metadata (2.5) #402

JessicaMarine opened this issue Dec 18, 2018 · 13 comments
Assignees
Labels
Milestone

Comments

@JessicaMarine
Copy link

JessicaMarine commented Dec 18, 2018

As a Petitioner, in order to give the Court necessary case related information, I need to provide certain metadata.

Before submitting the case to the Court, Petitioner will enter/select additional case metadata, such as:
Type of Case
Small v. Regular Case
Place of Trial

Some of the metadata will be REQUIRED fields and the Petitioner will be stopped from submitting their Petition unless those fields are completed.

Pre-Conditions:

  • Petitioner is logged into the System
  • Petitioner has elected to “Start a New Case”

Acceptance Criteria:

  • Petitioner can enter Date of IRS notice (if any) [Note: actual notice upload function is story Petitioner: Upload IRS Notice (2.4) #401]
  • Petitioner can select the type of Case (Deficiency, Collection Due Process, Innocent Spouse, Whistleblower, etc.)--REQUIRED*
  • Petitioner can select whether they want case conducted as Small v. Regular (Procedure Type) and can view information about the differences --REQUIRED*
  • Petitioner can select Place of Trial (options should be intuitively driven based on selection of small v. regular)--REQUIRED*
  • All metadata should be saved in the System upon case submission
  • All metadata is viewable to internal Court users on the case information tab
  • The Place of Trial selected should be displayed on the Docket Record as “Request for Place of Trial at City, State"
  • If Petitioner does not enter required metadata, they should be stopped from submitting their Petition.
  • The Court is confident the data submitted by the Petitioner is accurate

Notes:

  • The PDF upload functions for Place of Trial and STIN can be removed
  • Need a list of all Places of Trial and whether they conduct small or regular procedure types (Jessica provided in comments)
  • Need a complete list of case types (Jessica provided in comments)
  • (1/8) Can leave a dead upload link. It will go live when we do Petitioner: Upload IRS Notice (2.4) #401. Include design elements. Just won't do anything.
  • (1/8) Design will incorporate a validation modal for the cancel button. "Are you sure?"
  • (1/8) Use full list of fields now. Can break up when we add yes/no logic.
  • (1/8) If a state doesn't have a city available, write some helper text instead of implementing some logic. "Please note, if you select small tax cases, there are no available trial sessions in the following states. Please select the next closest city."
  • (1/10) Override USDS design standards and don't wrap text next to textbox.
  • (1/10) Don't allow text to run all the way across the page. Instead, make about 75% across the page. Approx. 75 to 85 characters
  • (1/10) PDF icons need to be black, not blue.
  • (1/10) Sentences should be closer to the thing above it.
  • (1/0) Types of notice are ordered by most commonly used. ~80% of users will select the first two.
  • Sorting of the the Petitioner's Docket Record is not required for acceptance of this story. This will be addressed in Issue Filing Fee: Notate how and when paid or waived (by 1/8) #573

Tasks

  • 1. Design the "Start a New Case" form (Kristen)
  • 2. Add instructional text for Petition upload (Form 2 or custom petition)(Kristen)
  • 3. Update text to suggested plain language (Natalie)
  • 4. Design the "Case Information" tab (Kristen)
  • 5. Modify "Submit" action on the form to include additional metadata and required fields (Eric)
  • 6.1 Design the "Case Information" tab (Kris)
  • 6.2 Modify the "Case Information" tab to reflect live data(cody)
  • 7. Add fields to Case Detail record (will)
  • 8. Design how case type entities are connected to the case entity (will)
  • 9. Design how place of trial entity is connected to the case entity (will)
  • 10. Implement changes to the database based upon additional relationships (will)
  • 11. create interactors, actions, sequences for case types, procedure types, trial cities (will)
  • 12. add simple form to the filepetition view which can be changed later based on the design (will)
  • 13. remove stin and placeoftrial from fileapetition (will)
  • 14. Add validation and error messaging (Cody)
  • 15. Plug-in the cerebral tests to display the error messages
  • 16. Need to create the integration test for cerebral
    • see names listed below for assignment (Cody)
  • 17. Develop BDD test scenarios
  • 18. Add new styles to make App look like Figma (Eric)
  • 19. Create cancel modal (Kris)
  • 20. Research how to implement text not spanning the entire page; esp in light of responsive design (Natalie)
  • 21. Determine what we're doing with PDF icons (Natalie)
  • 22. Upload Petition Helptext (see design in comment jan 11 2019)
  • 23. Research file size limitation solutions as it applies to court documents. (Waldo)
  • 24. Add "Other" to case types (Will) pr out
  • 25. Coordinate with User Design on Error Handling (Will, Eric, and Natalie)
  • 26. Tie preferredCity, trialcities, proceduretype and irsNoticeDate to the form in the view (will/cody)
  • 27. If user clicks Yes on the modal, they return to the dashboard. (kris)
  • 28. clear the form data on page load (kris)
  • 29. the select dropdown for state should use optgroup for grouping by state (cody)
  • 30. trial cities hint should change depending on the selected procedureType
    -add to start a case helper computed (will/eric)
  • 31. update the success alert to match design (cody)
  • 32. format the irsNoticeDate on the case information tab to be MM/DD/YYYY (kris)
  • 33. implement the checkbox for "I have reviewed" to not allow the form to submit (cody)
  • 34. hide the current validation messages and display a generic message instead (cody)
  • 35. bring back the functionality to marking a case as paid (kris)
  • 36. revisit the date inputs validation (Eric/Will)
    • a. Date field should accept only numeric values
    • c. Date cannot be in the future
  • 37. implement the "how is a small case different than a regular case" accordion (kris)
  • 38. PDF Help Text - Petitioner: Enter Case Metadata (2.5) #402 (comment) - (cody)
  • 39. address bugs posted in slack by jessica 1/13 (will) (prs out)
  • 40. add trial city as described in AC to the petitioner view similar to paygov date (note - the underlying data structure and code behind this view will be refactored in a later story) (will)
  • 41. adjust body copy width (Eric, Natalie, Kristen)

Test Scenarios

When initiating a petition (start a case):

  • petitioner sees all available options for case types and can only select one option (will)
  • petitioner sees options available for procedure type (Small or Regular) and can only select one option (will)
  • after choosing a procedure type, petitioner sees all available options for preferred trial locations based on the selected procedure type and petitioner can select only one preferred trial location (will)
  • changing the selected procedure type causes the selected trial location to reset (will)
  • petitioner can select a single petition pdf (will)
  • petitioner should be prompted to indicate that they have reviewed all information before submitting case to the Court
  • when petitioner submits form a case is not initiated unless caseType, procedureType, preferredTrialLocation, and petitionPdf are present and valid. (cody)
  • all fields are saved to the case and the petitioner can view the newly created case (cody/will)
  • case metadata is viewable to internal court users on "Case Information" tab in case

Definition of Done

  • acceptance criteria have been met
  • all code changes have been reviewed, approved, and merged and deployed to develop
  • all automated unit tests are passing on all supported browsers with coverage > 90%
  • run the browser stack scripts to verify that application is usable in Chrome, Firefox, Safari, Edge and Internet Explorer
  • all automated a11y checks are passing - no new WCAG2.1 or AA contrast issues present
  • 0 errors reported in manual a11y testing
  • all new functionality verified to work with keyboard and osx voiceover
  • all code quality checks are passing - sonar, eslint, html validation, etc.
  • code refactored for clarity and to remove any known technical debt
  • application can be deployed to multiple regions
  • README, other appropriate docs, and swagger/APIs fully updated - all code functions documented with jsdocs
  • performance tests successfully completed and no new significant performance issues found
  • alerting and monitoring for new functionality in place and successfully exercised
  • ui should be touch optimized and responsive (functions on supported mobile devices and optimized for screen sizes as required)
  • usability has been validated
  • npm audit for CVE’s in production library/module dependencies identified and resolved
  • library/module dependencies are up-to-date and are at the latest resolvable version
@JessicaMarine JessicaMarine changed the title Petitioner: Enter Case Metadata Petitioner: Enter Case Metadata (2.5) Dec 18, 2018
@tjcurington tjcurington added this to the Sprint #5 milestone Dec 19, 2018
@JessicaMarine
Copy link
Author

Here are the lists of trial cities that should be available for both small and regular cases:

Trial Cities for Regular Tax Cases.xlsx
Trial Cities for Small Tax Cases.xlsx

@JessicaMarine
Copy link
Author

JessicaMarine commented Dec 20, 2018

@sadlerw Here is the list of Case Types:

 Deficiency--Notice of Deficiency
 CDP (Lien/Levy)--Notice of Determination Concerning Collection Action
 Innocent Spouse--Notice of Determination Concerning Relief From Joint and Several Liability Under Section 6015
 Readjustment of Partnership Items Code Section 6226
 Adjustment of Partnership Items Code Section 6228
 Partnership Action Under BBA Section 1101
 Whistleblower--Notice of Determination Under Section 7623 Concerning Whistleblower Action
 Worker Classification--Notice of Determination of Worker Classification
 Declaratory Judgment (Retirement Plan)
 Declaratory Judgment (Exempt Organization)
 Passport --Notice of Certification of Your Seriously Delinquent Federal Tax Debt to the Department of State
 Interest Abatement--Notice of Final Determination for Full or Partial Disallowance of Interest Abatement Claim (or Failure of IRS to Make Final Determination Within 180 Days After Claim for Abatement)

@klohman
Copy link

klohman commented Jan 8, 2019

@JessicaMarine @uxforgood @sadlerw @dubharmonic
Form designs:

When taxpayer logs into their account, the dashboard is displayed. On click of Start a Case button, the Start a Case form will open.

Dashboard- Petitioner.png

Start a Case Form
Notes:

  • USTC Form 2 links to https://www.ustaxcourt.gov/forms/Petition_Simplified_Form_2.pdf

  • Tax Court Rules of Practice and Procedure links to https://www.ustaxcourt.gov/rules.htm

  • All displayed fields are required

  • Did you receive a notice from the IRS field- will eventually be a Yes/No radio set but for this story will only include Yes

  • Date of Notice

    • Date field should accept only numeric values
    • Date field should add leading zero to any single digit month or day entered
    • Date cannot be in the future
    • Month and Day fields should auto tab to the next field when 2 digits are entered
  • Who is filing this petition?

    • Will eventually be several radio buttons but for this story, only Myself is an option
      Start a Case Form - Full Single Page.png
  • How is a small case different than a regular case, and do I qualify- link should expand to show the Small Case Expandable (see screenshot below)

  • On click of the How is a small case different than a regular case, and do I qualify - the expanded section should collapse
    Start a Case Form - Small Case Expanded.png

  • Case Procedure

    • On select of Regular or Small Tax Case, the Select a Trial Location dropdown displays
    • Dropdown is populated with cities dependent on the case procedure type (see the trial cities lists Jessica provided in comment above).
    • Helper text is displayed
      • If Regular Case is selected, display: Trial locations are unavailable in the following states: DE, KS, ME, NH, NJ, ND, RI, SD, VT, WY. 
Please select the next closest location.
      • if Small case is selected, display: Trial locations are unavailable in the following states: DE, NH, NJ, RI. 
Please select the next closest location.

Start a Case Form - Full Single Page - with Location.png

Select a Trial Location dropdown should be ordered by state alphabetically

  • State is displayed but cannot be selected

Location Dropdown.png

If user clicks on the Cancel button, display confirmation modal. If user clicks Yes, cancel, they return to the dashboard and all form data is discarded. If they click, No, continue, the modal should close and they remain on form page.
Screen Shot 2019-01-08 at 10.30.05 AM.png

If all fields have been completed, and user clicks on Submit to U.S. Tax Court button, the form is submitted and user returns to the dashboard where a success message is displayed.

Dashboard- Petition Success.png

@klohman
Copy link

klohman commented Jan 8, 2019

@JessicaMarine @uxforgood @sadlerw @dubharmonic

Error State - Form validation

  • on Click of Submit to U.S. Tax Court button - should validate that all fields have been completed.
  • If any required field is empty, display page level error message (as shown) with list of all incomplete fields. Also, incomplete fields should display in their field level error state (see Select a Trial Location field in mockup)

Page level errors (both the warning at the top and the indicators by the field) remain until the form has been submitted again. If errors remain or new ones are found, page level errors load again. If form is error-free, form is submitted successfully.

Start a Case Form - Full Single Page -Error State.png

Field level validation

For date of notice - once user has entered numbers in all 3 date fields and focuses outside the date field, check to make sure the date is
A) valid
B) NOT in the future

If not valid, display a field level error that says "Please enter a valid date"
If in the future, display a field level error that says "That date's in the future. Please enter a valid date."

When user loses focus on date fields, check again. If error is fixed, remove error message/state.

@klohman
Copy link

klohman commented Jan 8, 2019

@JessicaMarine @kkoskelin

Case Information Tab - with new metadata

  • Metadata provided during the petition submission will display on the Case Information tab on the Case Detail page
  • Assigned Judge- if the case has not yet been set for trial and assigned to a judge, display "Not assigned"
  • Trial Date - if the case has not yet been set for trial, display "Not scheduled"
    Internal - Case Detail - Case Information Tab.png

@JessicaMarine
Copy link
Author

@sadlerw @dubharmonic @uxforgood @klohman Just a reminder that the actual IRS notice upload function is NOT part of #402. That is a separate story (#401). I've left everything in here the same, but added that note. For this story, I think having a mock upload function that is disabled for now is sufficient.

@uxforgood
Copy link

@JessicaMarine as part of your review of these designs, please take a look at the proposed language and provide feedback. Thanks!

@vbey
Copy link

vbey commented Jan 10, 2019

Notes from Design Meeting Jan 10 2019

Design Meeting Topic: Error Messaging
Decision: Leave error messaging functionality as-is for now, page level error messaging...that satisfies the requirement for error messaging and requires no additional effort at this time. (This decision is non-binding, and intended to be a solution that will be revisited following usability testing.)

Background: Field level vs. page level validation? Validation will still be run. All field level error messaging will be handled the same visually. All page level error messaging will be handled the same visually. Do we follow the USWDS standard of field level validation which tells the user what the error is, or do we not?

We can probe error messaging with users during usability testing. Do they expect field level validation to happen prior to hitting the submit button?

@klohman
Copy link

klohman commented Jan 10, 2019

@JessicaMarine @kkoskelin @sadlerw @dubharmonic
Updated design with these changes

  • Revised the form instructions at the top (added section header, changed icon color and size, changed spacing)
  • Removed the radio buttons for "Did you receive an IRS notice" and "Who is filing a petition" - the options for these fields will be discussed in later stories
    Start a Case Form - Full Single Page.png

Start a Case Form - Small Case Expanded.png

Start a Case Form - Full Single Page - with Location.png

@klohman
Copy link

klohman commented Jan 11, 2019

@codyseibert @sadlerw @JessicaMarine

Error messaging

  • if errors were found in the form upon submission, display a page- level message (see design).
  • do not display any field level error messaging (to be added after usability testing in another story)
  • do not list the field labels with errors in page-level message (to be added after usability testing in another story)
  • page level message will be remain until the form is resubmitted

Screen Shot 2019-01-11 at 9.39.38 AM.png

@mariahkannenberg mariahkannenberg added the (1) File a Petition Epic 1: File a Petition label Jan 11, 2019
@klohman
Copy link

klohman commented Jan 11, 2019

PDF help text added to design

Screen Shot 2019-01-11 at 1.17.14 PM.png

@JessicaMarine
Copy link
Author

My comments on #402 are:

  1. In the “Are You Ready?” instructional area, can we please hyperlink to “Form 2” and “Tax Court Rules of Practice and Procedure”
  2. The hyperlinks to “Form 2” and “Tax Court Rules of Practice and Procedure” under “Tell Us About Your Petition” currently take you back to the dashboard with an error message. Please hyperlink to proper URL
  3. In the Place of Trial dropdown, some of the city options are bolded. The states should be bolded, but all city options should not be
  4. Are we planning to have the leading zeros in the date for MM and DD autocompleted if not entered. For example, if I enter 2 15 2019, would it automatically correct to 02 15 2019?
  5. The place of trial selected is not showing up as a docket entry. The AC for that is: The Place of Trial selected should be displayed on the Docket Record as “Request for Place of Trial at City, State"
  6. Small design issue I noticed -- When I’m in a case, the Docket Number at the top of the page should be Docket Number versus Docket number.

@uxforgood
Copy link

@sadlerw @dubharmonic

To make it official, here's the new checkbox design for the bottom of the form.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants