Messaging Re-design clean up - Remove old messaging flow

[JessicaMarine]

As a development team, in order to maintain a clean code base and ensure the changes we made to the messaging flow work, we need to remove all of the old messaging flow items that are not used for the new flow and run E2E tests on the new flow.

Pre-Conditions

• Revisit flow: Proposed/Signed Stipulated Decision #5841/Revamping the stip decision flow

Acceptance Criteria

• Disable old messaging flow
• Test new messaging flow - E2E
• Remove "Messages" tab from Document QC pages, as well as any other UI remnants from the old flow
• Old document detail page is removed
• Once we remove "Messages" from the global header, we need to rename "Case Messages" to "Messages" and make sure everything is renamed correctly on the back end.

Mobile Design/Considerations

Security Considerations

• Does this work make you nervous about privacy or security?
• Does this work make major changes to the system?
• Does this work implement new authentication or security controls?
• Does this work create new methods of authentication, modify existing security controls, or explicitly implement any security or privacy features?

Notes

Tasks

• 1) Remove old Messages link in the page header and replace with Case Message (Mrin & Rae & Rachael 5411: remove old messaging boxes #6048)
• 2) Remove old Messages views (Mrin & Rae & Rachael 5411: remove old messaging boxes #6048)
  • Remove route
• 3) Remove old Document Detail view (Rachael 5511: remove document detail view, route, update integration tests #6040)
  • Remove route (Rachael 5511: remove document detail view, route, update integration tests #6040)
• 4) Remove old Message entity (Rachael 5511: remove messages from work items #6042)
• 5) Remove Messages from Work Items (Rachael 5511: remove messages from work items #6042)
• 6) Remove Messages tab from Document QC pages (Rachael 5511: remove document QC messages tab #6043)
• 7) Update all references of Case Message to Message(Mrinalini) 5511 Change all references to 'CaseMessage(s)' to be 'Message(s)' #6060
• 8) Remove WorkItem isQC (Rachael 5511: remove isQC from work items #6052)
• 9) Remove workQueueIsInternal (Rachael 5511: remove workQueueIsInternal; clean up logic #6050)
• 10) Convert Document.workItems to a single object instead of an array (Rachael 5511: convert Document.workItems into a single object instead of an array #6062)
• 11) Remove createWorkItemInteractor (Rachael 5511: remove createWorkItemInteractor #6044)
• 12) Remove SignStipDecision.jsx and route, sequences (Rachael 5511: remove SignStipDecision.jsx #6045)
• 13) Remove/clean up documentDetailHelper (Rachael 5511: remove documentDetailHelper and DocumentDetailHeader #6047)
• 14) Remove/clean up DocumentDetailHeader (Rachael 5511: remove documentDetailHelper and DocumentDetailHeader #6047)
• 15) Remove endpoints/persistence methods for old messaging (Rachael 5511: remove old messaging endpoints #6056)
• 16) Rename CaseMessage* views to Message* (Rachael 5511: rename CaseMessage views to Message #6072)
• 17) Rename /case-message/* routes to /message/* (Rachael 5511: update /case-messages routes to /messages #6073)
• 18) Remove code related to old messaging view - CreateMessageModalDialog, ForwardMessage entity (Rachael 5511: remove more old messaging code #6074)
• 19) Update actions, sequences, proxies, interactors, computeds, etc with CaseMessage in the name to Message (Rachael)

Definition of Done (Updated 7-2-20)

Product Owner

• Acceptance criteria have been met
  UX
• Business test scenarios to meet all acceptance criteria have been written
• Usability has been validated
• Wiki has been updated (if applicable)
• Story has been tested on a mobile device (for external users only)

Engineering

• Automated test scripts have been written
• Field level and page level validation errors (front-end and server-side) integrated and functioning
• Paired w/Mark on data migration work (if applicable)
• Verify that language for docket record for internal users and external users is identical
• New screens have been added to pa11y scripts
• All new functionality verified to work with keyboard and macOS voiceover https://www.apple.com/voiceover/info/guide/_1124.html
• READMEs, other appropriate docs, JSDocs and swagger/APIs fully updated
• UI should be touch optimized and responsive for external only (functions on supported mobile devices and optimized for screen sizes as required)
• Module dependencies are up-to-date and are at the latest resolvable version (npm update)
• Errors in Sonarcloud are fixed https://sonarcloud.io/organizations/flexion-github/projects
• Lambdas include CloudWatch logging of users, inputs and outputs
• Code refactored for clarity and to remove any known technical debt
• Rebuild entity documentation
• Acceptance criteria for the story has been met
• Deployed to the dev environment
• Deployed to the stage environment

[klohman]

Tests

• Send message without a document attached (Court: Send case message without document #4293) - Rachael
• Send message with a document attached (Court: Send case message with a document "attached" #4607) - Rachael
• Forward message (Court: Message complete, forward and reply  #4609) - Mrinalini
• Reply to message (Court: Message complete, forward and reply  #4609) - Kristen
• Complete message (Court: Message complete, forward and reply  #4609) - Kristen
• Create Order from message (Court: Create an order tied to a message thread #4611) - Kristen
• Apply and Edit Signature to document attached to message (Court: Take action on a document from the message thread #4612) - Kristen
• Edit document attached to message (Court: Take action on a document from the message thread #4612 Kristen
• Add Docket Entry for document attached to message (Court: Take action on a document from the message thread #4612) - Kristen
• Serve document attached to message (https://app.zenhub.com/workspaces/flexionef-cms-5bbe4bed4b5806bc2bec65d3/issues/flexion/ef-cms/5811) - Kristen
• View message thread (Court: Message complete, forward and reply  #4609) - Kristen
• View completed message thread (Court: Message complete, forward and reply  #4609) - Kristen
• Judge's view recent messages on their dashboard (https://app.zenhub.com/workspaces/flexionef-cms-5bbe4bed4b5806bc2bec65d3/issues/flexion/ef-cms/5810) - Kristen

[klohman]

Notes from Jessica (for testing).

(1) I don't think the Recent Messages on the Judge's dashboard is working as expected. I thought it was supposed to show the 5 most recent messages. Check out Judge Buch's -- it's not showing the 5 most recent and they aren't in newest-to-oldest order. (2) Also, in general, there is a lag in messages being added and removed from the Recent Messages on the Judge's dashboard. In staging, a DocketClerk1 sent a Proposed Stipulated Decision to jasford. That message wasn't displaying on the dashboard when I signed in as Judge Ashford. I had to click around a bit before it showed up. Then, when Judge Ashford replied to the message, it stayed on the Recent messages until I clicked around a bit again. (3) Also, when a Docket Clerk completes a message, it's not clearing it from the Inbox until you click around a bit. All of this messaging behavior has to work as expected.

[mrinsin]

(Kristen's findings)

• On message screen, clicked Create Order, clicked Continue on modal - new tab opens but displays 404 error - Rachael
• When adding docket entry for uploaded PDF draft, the message attachment still displays the original description and not what the docket entry states (is this related to https://app.zenhub.com/workspaces/flexionef-cms-5bbe4bed4b5806bc2bec65d3/issues/flexion/ef-cms/5893) - Addressed in 5893
• Message without any documents attached: if I attach a document when replying or forwarding - the attachment should be selected by default and display in PDF preview - Mrinalini 5511 bug fix #6102
• On Judge’s Dashboard “Recent Messages” - not showing the five most recent. Messages - Rachael 5511: delete old case message records; fix judge's dashboard recent messages #6098
  • See Judge Ashford’s Recent Messages
• Judge’s Dashboard Recent Message should sort from newest oldest - Rachael 5511: delete old case message records; fix judge's dashboard recent messages #6098
• Completed messages are still showing in Message Inbox - see Docket Clerk messages - Rachael 5511: delete old case message records; fix judge's dashboard recent messages #6098
• Completed messages still showing in Recent Messages (see Judge Ashford) - Rachael 5511: delete old case message records; fix judge's dashboard recent messages #6098
• unable to complete a message (case 103-20) test correspondence until i forwarded to another user (?) - should be fixed after migration runs

(Mrinalini's Findings)

• Bug - Clicking on the message link to a message with no attachments throws an error - should be fixed after migration runs

• Clicking on document from QC inbox, then clicking cancel should navigate back to document QC (currently navigating to Docket Record) - Rachael 5511: redirect back to document QC when canceling docket entry QC #6100

• - Rachael 5511: redirect back to document QC when canceling docket entry QC #6100