Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petitioner: International and Other Domestic Addresses and Phone Numbers #655

Closed
30 tasks done
JessicaMarine opened this issue Jan 17, 2019 · 3 comments
Closed
30 tasks done
Labels
closed (legacy) Delay Ship Indefinitely - No Engineering Engineers have started working on this story. (1) File a Petition Epic 1: File a Petition
Milestone

Comments

@JessicaMarine
Copy link

JessicaMarine commented Jan 17, 2019

As a Petitioner, In order to provide international addresses and phone numbers for any address I enter into the system, I need to the system to accommodate international address.

The Court occassionally has Petitioners who do not live in the United States. The System needs to be accomodate to international addresses.

Pre-Conditions:

  • Petitioner has decided to Start a New Case

Acceptance Criteria:

  • Petitioner must be able to enter an international/unusual address for any address they can enter into the system
  • The System can save and display international addresses

Tasks

  • 1. Modify the Start a Case Form (Rachael)
  • 2. Update pa11y tests for Start a Case Form (Rachael)
  • 3. Update seed data with new required fields and international addresses (Rachael - PR)
  • 4. Update taxpayerCreatesNewCase business test with required fields, intl addresses (Kris)
  • 5. Modify the Case Information page (William)
  • 6. Find a better way to use object composition for creating some of these contact entities (Cody / Kris)
  • 7. Dry up the strings we are using throughout the code base and components (Cody)
  • 8. Come up with validation requirements for international addresses (UX)
  • 9. Create validation routines for international addresses (Eric & William)
  • 10. Change zip to postal code throughout code (Rachael)
  • 11. Reminder to revisit string constants from a CA perspective as part of refactoring at the end of this story (also clean up incomponentPerson -> incompetentPerson) (Cody)
  • 12. Reminder to revisit default countryType in updatePartyTypeAction (William)

Definition of Done

  • acceptance criteria have been met
  • Field level and page level validation errors (front-end and server side) integrated and functioning
  • all code changes have been reviewed, approved, and merged and deployed to develop
  • all automated unit tests are passing on all supported browsers with coverage > 90%
  • run the browser stack scripts to verify that application is usable in Chrome, Firefox, Safari, Edge and Internet Explorer
  • all automated a11y checks are passing - no new WCAG2.1 or AA contrast issues present
  • 0 errors reported in manual a11y testing
  • all new functionality verified to work with keyboard and osx voiceover
  • all code quality checks are passing - sonar, eslint, html validation, etc.
  • code refactored for clarity and to remove any known technical debt
  • application can be deployed to multiple regions
  • README, other appropriate docs, and swagger/APIs fully updated - all code functions documented with jsdocs
  • performance tests successfully completed and no new significant performance issues found
  • alerting and monitoring for new functionality in place and successfully exercised
  • ui should be touch optimized and responsive (functions on supported mobile devices and optimized for screen sizes as required)
  • usability has been validated
  • npm audit for CVE’s in production library/module dependencies identified and resolved
  • library/module dependencies are up-to-date and are at the latest resolvable version
@JessicaMarine JessicaMarine added the (1) File a Petition Epic 1: File a Petition label Jan 17, 2019
@JessicaMarine JessicaMarine changed the title Clerk of the Court: International Addresses Petitioner: International Addresses Jan 17, 2019
@tjcurington tjcurington changed the title Petitioner: International Addresses Petitioner: International Addresses and Phone Numbers Jan 18, 2019
@tjcurington tjcurington changed the title Petitioner: International Addresses and Phone Numbers Petitioner: International and Other Domestic Addresses and Phone Numbers Feb 20, 2019
@tjcurington tjcurington added this to the Sprint #9 milestone Feb 20, 2019
@uxforgood uxforgood added the Design Needed Design work will be needed and development work should not start yet label Feb 21, 2019
@uxforgood
Copy link

uxforgood commented Feb 21, 2019

@ericsorenson @JessicaMarine summary of the design changes to accommodate International addresses.

In the Start a Case form, everywhere there is an address (so for each party type), please make the following changes/additions: [The Name field label below would stay dynamic to whatever party type it's set for - so no change there from what was implemented in 307]

Default addresses

  1. Add Country dropdown to the top with the following options
    • United States [default]
    • International
  2. Change "Street Address" to "Mailing Address"
  3. Change "Suite/Apt #" to "Address Line 2 (optional)"
  4. Add another optional field below Address Line 2 labeled "Address Line 3 (optional)"
  5. Update the States dropdown to include the following changes:
    • Add subheadings to selection groups (see the trial locations dropdown for design/example)
    • Subheadings should be "State" following by alpha listing of 50 states, then subheading "Other" followed by this list:
      AA
      AE
      AP
      AS
      FM
      GU
      MH
      MP
      PW
      PR
      VI

image.png

International addresses

If user selects "International" from the country dropdown, display the following fields (all are text fields, no dropdowns):

  • Country Name
  • [dynamic name label]
  • Mailing Address
  • Address 2 (optional)
  • Address 3 (optional)
  • State/Province/Region
  • City
  • ZIP/Postal Code

image.png

@uxforgood uxforgood added Engineering Engineers have started working on this story. and removed Design Needed Design work will be needed and development work should not start yet labels Feb 26, 2019
@kkoskelin
Copy link

@uxforgood I'm wondering about the International address "ZIP/Postal Code". The "ZIP" is a distinctly United States thing, as far as I know. Can we stick with 'Postal Code' for the label?

@uxforgood
Copy link

@kkoskelin Yes I think we can just label that Postal Code. We took that label and group of form elements from an example that didn't first distinguish between US and international addresses, so was accommodating both.

  1. Please change label to "Postal Code"
  2. Also, as discussed, please add (optional) and remove from required validation rules to state/province/region as some addresses don't include this (like the London, England example)

@sarahridgway @klohman @JessicaMarine for reference

This was referenced Feb 27, 2019
ericsorenson pushed a commit that referenced this issue Jan 25, 2021
Merge Staging into Migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed (legacy) Delay Ship Indefinitely - No Engineering Engineers have started working on this story. (1) File a Petition Epic 1: File a Petition
Projects
None yet
Development

No branches or pull requests

5 participants