Style guide tweaks #1070
Merged
Style guide tweaks #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsorenson
requested review from
codyseibert,
kkoskelin,
rachaelparris and
wbyoko
kkoskelin
suggested changes
Mar 12, 2019
| @@ -2,7 +2,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; | |||
| import React from 'react'; | |||
|
|
|||
| export const Interstitial = () => ( | |||
| <div className="progress-indicator"> | |||
| <div className="progress-indicator" aria-live="assertive"> | |||
There was a problem hiding this comment.
OK, but without a message (e.g. aria-label="one moment") the assertive value may not be entirely useful.
There was a problem hiding this comment.
Think we should just remove it?
kkoskelin
approved these changes
Mar 13, 2019
kkoskelin
pushed a commit
that referenced
this pull request
Apr 15, 2021
8078 - More explicit error logging, catch missing s3 files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.