Pull in Court Changes #1154
Merged
Pull in Court Changes #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sprint 7
The Court has committed to using Chrome internally, meaning that development can emphasize Chrome (though not to the detriment of other browsers), and eschew Internet Explorer 11. However, public-facing pages must function on the browsers that the public relies on, including IE 11.
Update testing process to reflect browser choices
Sprint 8
As of sprint 8, the volume of code exceeds what can be reasonably reviewed. Also, test coverage is high. Solution: this.
Update code review process to reflect testing emphasis
This describes the process that I talked through with Flexion last week.
Add a security audit of dependencies, other minor changes
Sprint 9
It doesn't work elsewhere, because it won't know where to find the SSH credentials.
It expects to be run in `management/management/`, and won't work elsewhere, because it expects `ssh/` to exist in the directory where it's run.
One list used two different types of bullets, another was outdented relative to the numbered list.
This leaves us one step short of PR building, but it's a fine start.
Update the setup instructions to match reality
A bunch of material was wrongly under the `Running this project locally without Docker` heading.
Minor edits to make the Readme more clear
Every couple of sprints, there's a problem that has resulted from cached Docker assets. And every couple of sprints, I get 15 minutes into the code review before I realize that I haven't updated my local copy. This step will prevent these problems.
Start off code reviews with a blank slate
wbyoko
approved these changes
Mar 19, 2019
rachaelparris
pushed a commit
that referenced
this pull request
Apr 30, 2021
7857: fixing presence of Delete button on many modals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulling in waldos readme changes