forked from ustaxcourt/ef-cms
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprint 3 PR #249
Merged
Merged
Sprint 3 PR #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to Use Shared Entities / Use Cases
configurable sonar project keys
could indicate bad commit in index.js with hard-coded credentials?
Consolidating web client tests
restoring cypress tests WIP
This is a rewrite of SETUP.md, in which I stepped through the whole process to make the instructions more explicit, and also moved it from something more outline-based to something more prose-like.
…into sprint-2-review
Addressing some PR comments
Shuffle around the contents for a more natural ordering.
127 Untracked input fix
* add a toggle and use is-visible
* add the date to the Case prototype when payGovId is there but no date * put it back on the json to save (better way?) * fix views
* add a toggle and use is-visible
* add userId and createdAt to the Cases documents schema * lint issue in dynamo persistence * return documentMetadata objects not just ids in the uploadcasepdfs use case * pass the documents returned from persistence/use case back to the createCase use case instead of making them anew
* add jsdoc
E2e enhancements
127 make search responsive
127 save a paygov updatedAt
127 fix document dates
increasing default instance size
add jsdoc to business module
adding some documentation about how to add swap just in case
Sprint 3 Deploy
adding a missed swap step
Validate error or success; don’t navigate and count rows
Refine cypress test
Fixing Cypress Test
kkoskelin
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Deploy Steps (Do these in order)