Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4609: filter out messages older than 7 days from Sent and Completed boxes #5571

Merged
merged 4 commits into from
Jun 22, 2020

Conversation

rachaelparris
Copy link

@rachaelparris rachaelparris commented Jun 22, 2020

Also included a fix for refreshing the case messages when sending a new one from the case detail page.

Copy link

@sutt0n sutt0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, granted unit test additions/changes are coming in a future PR for the ElasticSearch methods 😄

@rachaelparris
Copy link
Author

Looks good, granted unit test additions/changes are coming in a future PR for the ElasticSearch methods 😄

I just spoke with Kris about this. I'm not sure what else there is to unit test. Jest shows 100% coverage. Is there something you would like to see added to the tests?

@rachaelparris rachaelparris merged commit 7ee4148 into develop Jun 22, 2020
@rachaelparris rachaelparris deleted the 4609-messages-older-than-7-days branch June 22, 2020 20:34
jimlerza added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants