Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4611: submit order from message and add as attachment #5599

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

rachaelparris
Copy link

No description provided.

* @param {object} providers.applicationContext the application context
* @param {string} providers.caseId the id of the case
* @param {string} providers.messageId the id of the message
* @returns {object} the created case message

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the retrieved case message

@@ -218,4 +218,10 @@ CaseMessage.prototype.markAsCompleted = function ({ message, user }) {
return this;
};

CaseMessage.prototype.addAttachment = function (attachmentToAdd) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: jsdoc

@rachaelparris
Copy link
Author

I'll fix the jsdocs in the next PR

@rachaelparris rachaelparris merged commit 4b8ba2f into develop Jun 24, 2020
@rachaelparris rachaelparris deleted the 4611-submit-create-order branch June 24, 2020 15:17
nechama-krigsman pushed a commit that referenced this pull request Nov 27, 2024
10553: Add retry when entity is locked;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants