fix: add back splash activity #1167

kasinskas · 2023-10-13T06:33:06Z

error i was getting:

│ [ error ] [configure] Cannot write file. source path doesn't exists: renative/packages/engine-rn/templates/platforms/android/app/src/main/java/rnv/SplashActivity.kt

mihaiblaga89 · 2023-10-13T07:19:16Z

packages/sdk-android/src/kotlinParser.ts

@@ -173,13 +173,14 @@ export const parseMainActivitySync = (c: any) => {
 export const parseSplashActivitySync = (c: Context) => {
    const appFolder = getAppFolder(c);
    const { platform } = c;
-    const splashPath = 'app/src/main/java/rnv/SplashActivity.kt';
+    const splashTemplatePath = 'app/src/main/java/rnv_template/SplashActivity.java.tpl';
+    const splashPath = 'app/src/main/java/rnv/SplashActivity.java';


@kasinskas the destination path needs to be inside the correct folder, like src/main/java/com/app/...., check

renative/packages/sdk-android/src/kotlinParser.ts

Line 127 in c98b67d

const javaPackagePath = `app/src/main/java/${javaPackageArray.join('/')}`;

* main: chore: update gradle overrides default values add NDK_VERSION dyna prop

kasinskas added 2 commits October 12, 2023 19:47

fix: add splash activity back

0cb139a

chore: splash activity template

c98b67d

mihaiblaga89 suggested changes Oct 13, 2023

View reviewed changes

kasinskas and others added 2 commits October 13, 2023 12:34

fix: splash destination path

f46b132

raise SWIFT_VERSION to 5.0

d2939dc

Base automatically changed from fix/gradle_overrides to main October 13, 2023 17:36

Merge branch 'main' into fix/splash-activity

d66cd0d

* main: chore: update gradle overrides default values add NDK_VERSION dyna prop

mihaiblaga89 self-assigned this Oct 16, 2023

mihaiblaga89 approved these changes Oct 16, 2023

View reviewed changes

mihaiblaga89 merged commit 781b06e into main Oct 16, 2023
3 checks passed

pavjacko added this to the 1.0 milestone Dec 8, 2023

pavjacko deleted the fix/splash-activity branch February 14, 2024 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add back splash activity #1167

fix: add back splash activity #1167

kasinskas commented Oct 13, 2023 •

edited

Loading

mihaiblaga89 Oct 13, 2023

kasinskas Oct 13, 2023

fix: add back splash activity #1167

fix: add back splash activity #1167

Conversation

kasinskas commented Oct 13, 2023 • edited Loading

mihaiblaga89 Oct 13, 2023

Choose a reason for hiding this comment

kasinskas Oct 13, 2023

Choose a reason for hiding this comment

kasinskas commented Oct 13, 2023 •

edited

Loading