Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tizen paths for packaging apps #1184

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix tizen paths for packaging apps #1184

merged 2 commits into from
Oct 20, 2023

Conversation

mihaiblaga89
Copy link
Contributor

@mihaiblaga89 mihaiblaga89 commented Oct 18, 2023

const tOut = path.join(tDir, 'output');
const tIntermediate = path.join(tDir, 'intermediate');

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This path concatenation which depends on
library input
is later used in a
shell command
.
copyFileSync(tProjectFile, path.join(tBuild, '.tproject'));
copyFileSync(configXml, path.join(tBuild, 'config.xml'));

await execCLI(c, CLI_TIZEN, `build-web -- ${tBuild} -out ${tIntermediate}`);

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This string concatenation which depends on
library input
is later used in a
shell command
.
This string concatenation which depends on
library input
is later used in a
shell command
.
copyFileSync(configXml, path.join(tBuild, 'config.xml'));

await execCLI(c, CLI_TIZEN, `build-web -- ${tBuild} -out ${tIntermediate}`);
await execCLI(c, CLI_TIZEN, `package -- ${tIntermediate} -s ${certProfile} -t wgt -o ${tOut}`);

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This string concatenation which depends on
library input
is later used in a
shell command
.
This string concatenation which depends on
library input
is later used in a
shell command
.
This string concatenation which depends on
library input
is later used in a
shell command
.
@pavjacko pavjacko self-assigned this Oct 20, 2023
* main: (35 commits)
  add ts-coverage tool
  update json schema, fix config loading
  any killing spree
  type coverage, kill any
  types for program, workspaces, runtimes
  typefy context cli
  strong type for c.program
  kill any
  rename RenativeConfigFile to ConfigFileBuildConfig
  add runtime config schema, cleanup
  npm types fixes
  typed npm package files
  clean code
  fix/buildHooks_path
  context type hardening
  typed project template
  typed plugin templates
  finish config  file type migration
  more ts fixes
  ts fixes
  ...

# Conflicts:
#	packages/template-starter/package.json
@pavjacko pavjacko merged commit 98d3e18 into main Oct 20, 2023
1 check passed
@pavjacko pavjacko deleted the fix/tizen_app_package branch October 20, 2023 00:46
@pavjacko pavjacko added this to the 1.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants